From: Jeff Garzik <jeff@garzik.org>
To: akpm@linux-foundation.org
Cc: linux-ide@vger.kernel.org, htejun@gmail.com
Subject: Re: [patch 2/4] libata: implement ata_wait_after_reset()
Date: Thu, 25 Oct 2007 06:12:19 -0400 [thread overview]
Message-ID: <47206C03.8080902@garzik.org> (raw)
In-Reply-To: <200710162121.l9GLLOv5017808@imap1.linux-foundation.org>
akpm@linux-foundation.org wrote:
> From: Tejun Heo <htejun@gmail.com>
>
> On certain device/controller combination, 0xff status is asserted
> after reset and doesn't get cleared during 150ms post-reset wait. As
> 0xff status is interpreted as no device (for good reasons), this can
> lead to misdetection on such cases.
>
> This patch implements ata_wait_after_reset() which replaces the 150ms
> sleep and waits upto ATA_TMOUT_FF_WAIT if status is 0xff.
> ATA_TMOUT_FF_WAIT is currently 800ms which is enough for
> HHD424020F7SV00 to get detected but not enough for Quantum GoVault
> drive which is known to take upto 2s.
>
> Without parallel probing, spending 2s on 0xff port would incur too
> much delay on ata_piix's which use 0xff to indicate empty port and
> doesn't have SCR register, so GoVault needs to wait till parallel
> probing.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/ata/ahci.c | 11 +----
> drivers/ata/libata-core.c | 67 +++++++++++++++++++++++++++-------
> drivers/ata/pata_scc.c | 13 +-----
> drivers/ata/sata_inic162x.c | 2 -
> include/linux/libata.h | 8 ++++
> 5 files changed, 67 insertions(+), 34 deletions(-)
applied
prev parent reply other threads:[~2007-10-25 10:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 21:21 [patch 2/4] libata: implement ata_wait_after_reset() akpm
2007-10-25 10:12 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47206C03.8080902@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.