From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerry Van Baren <gerald.vanbaren@ge.com>
Date: Thu, 25 Oct 2007 07:14:21 -0400
Subject: [U-Boot-Users] Fixup of fdt with detected memory size instead
 of fixed values
In-Reply-To: <47F3F98010FF784EBEE6526EAAB078D1024F8799@tq-mailsrv.tq-net.de>
References: <47F3F98010FF784EBEE6526EAAB078D1024F8799@tq-mailsrv.tq-net.de>
Message-ID: <47207A8D.2020608@ge.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Martin Krause wrote:
> Kim Phillips wrote on Thursday, October 25, 2007 12:55 AM:
>> On Wed, 24 Oct 2007 18:41:51 +0200
>> "Martin Krause" <Martin.Krause@tqs.de> wrote:
>>
>>> feature for all boards? AFAIK bd->bi_mestart and bd->bi_memsize
>>> should contain valid values on all boards. So why not fixup the
>>> "memory" node for all boards in ft_setup()? Does this make sense?
>> I think you're looking at the old CONFIG_OF_FLAT_TREE code, which has
>> since been superseded by CONFIG_OF_LIBFDT code.
> 
> You are right, I mixed up the two methods ...
> 
>> In 83xx, all boards' /memory fixup occurs in ft_cpu_setup in
>> cpu/mpc83xx/cpu.c, but, yes, I agree, it should be put somewhere even
>> more common.
> 
> What about moving the 83xx fixup code to cmd_bootm.c directly before/after
> the ft_board_setup() call? Then the memory fixup is done globally for all
> boards and dont't has to be implemented many times in the several 
> ft_cpu_setup() or ft_board_setup() functions. Any Comments? Otherwise
> I'm fine with doing it in ft_board_setup() for the TQM5200 board (copy &
> paste it from cpu/mpc83xx/cpu.c ;-)
> 
> Best Regards,
> Martin Krause

Hi Martin, et al.

I would rather see it in common/fdt_support.c.  The bootm command source 
file has already collected so much loosely related stuff it is hard to 
understand, so I hate to add more stuff to it.

gvb