From: "Denis V. Lunev" <den@sw.ru>
To: "Denis V. Lunev" <den@openvz.org>
Cc: davem@davemloft.net, devel@openvz.org, netdev@vger.kernel.org,
containers@lists.osdl.org, benjamin.thery@bull.net,
clg@fr.ibm.com
Subject: Re: [PATCH] remove __net_initdata attribute
Date: Fri, 26 Oct 2007 15:28:32 +0400 [thread overview]
Message-ID: <4721CF60.5060600@sw.ru> (raw)
In-Reply-To: <20071026095652.GA8788@iris.sw.ru>
Dave, I am sorry, plz disregard the patch :(
- if the file is a part of the kernel, __exit (and pernet_unregister)
will never called and should be dropped
- if the file is a part of a module, __init is NOT dropped on the
module loading stage
So, we can still make embedded people happy :) Thanks Pavel to pointing
me this out.
Denis V. Lunev wrote:
> The discussion with Eric W. Biederman reveals that the concept for
> __net_initdata is bogus. The ->exit method of pernet_operations
> should be called during module exit.
>
> So, discard this attribute.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
next prev parent reply other threads:[~2007-10-26 11:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 9:56 [PATCH] remove __net_initdata attribute Denis V. Lunev
2007-10-26 11:28 ` Denis V. Lunev [this message]
2007-10-26 11:41 ` David Miller
2007-10-26 11:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4721CF60.5060600@sw.ru \
--to=den@sw.ru \
--cc=benjamin.thery@bull.net \
--cc=clg@fr.ibm.com \
--cc=containers@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=den@openvz.org \
--cc=devel@openvz.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.