From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] skye/skge: sparse fix - data can't ever be bigger than LONG_MAX / HZ
Date: Fri, 26 Oct 2007 15:15:25 -0700 [thread overview]
Message-ID: <472266FD.8040005@intel.com> (raw)
In-Reply-To: <20071026151240.0ce5f7ec@freepuppy.rosehill>
Stephen Hemminger wrote:
> On Fri, 26 Oct 2007 15:10:28 -0700
> Auke Kok <auke-jan.h.kok@intel.com> wrote:
>
>> Trivial replacement - use INT_MAX instead here.
>>
>> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
>> Cc: shemminger@linux-foundation.org
>
> Acked-by: Stephen Hemminger <shemminger@linux-foundation.org>
>
> Sure that works. Note: original code was copied from e100 which I assume
> is why you found/fixed this case.
I went over your sparse fixes and decided to fix that last warning that you had
not fixed. I thought I might as well fix those poor drivers that copied our
bad-ass code ;)
still testing the code you sent me though... hopefully not much longer.
Auke
next prev parent reply other threads:[~2007-10-26 22:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 22:10 [PATCH] skye/skge: sparse fix - data can't ever be bigger than LONG_MAX / HZ Auke Kok
2007-10-26 22:12 ` Stephen Hemminger
2007-10-26 22:15 ` Kok, Auke [this message]
2007-10-29 10:05 ` Jeff Garzik
2007-10-29 15:32 ` Stephen Hemminger
2007-10-29 15:48 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=472266FD.8040005@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.