From: Jeff Garzik <jeff@garzik.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Salyzyn, Mark" <mark_salyzyn@adaptec.com>,
linux-kernel@vger.kernel.org, ebiederm@xmission.com
Subject: Re: [PATCH 7/9] irq-remove: scsi driver trivial
Date: Fri, 26 Oct 2007 20:12:40 -0400 [thread overview]
Message-ID: <47228278.8070505@garzik.org> (raw)
In-Reply-To: <20071026165035.33383e36@laptopd505.fenrus.org>
Arjan van de Ven wrote:
> On Fri, 26 Oct 2007 17:47:58 -0400
> Jeff Garzik <jeff@garzik.org> wrote:
>
>> Andrew Morton wrote:
>>> That was a goofup. I proposed that we should add a #define
>>> TWO_ARG_IRQ_HANDLERS (or whatever) and I think I actually wrote the
>>> patch, but it got lost.
>>>
>>> I agree it would be a kind thing to do in this case.
>
>>
>> Yep, I was thinking that including
>>
>> #define IRQ_HANDLER_V3
>>
>> would be a good idea.
>>
>
> it sets a certain precedent though.... we don't do this for the 500
> other API changes we do each release (see stable-api-nonsense)... so
> this one is mostly arbitrary picked out
We do for include/linux/netdevice.h, see HAVE_xxx -- and we should do it
because the last irq handler change was a pain for backports, and this
makes life easier for the backporters. irq handling is probably far
more global than any other kernel API except kmalloc()
Jeff
next prev parent reply other threads:[~2007-10-27 0:12 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 7:54 [PATCH 0/9] Remove 'irq' argument from all irq handlers Jeff Garzik
2007-10-19 7:55 ` [PATCH 1/9] irq-remove: core Jeff Garzik
2007-10-19 17:27 ` Eric W. Biederman
2007-10-19 17:48 ` Jeff Garzik
2007-10-19 18:04 ` Eric W. Biederman
2007-10-19 18:21 ` Jeff Garzik
2007-10-19 19:50 ` Eric W. Biederman
2007-10-19 19:58 ` Jeff Garzik
2007-10-19 23:13 ` Eric W. Biederman
2007-10-19 23:46 ` Jeff Garzik
2007-10-19 23:53 ` Jeff Garzik
2007-10-19 7:55 ` [PATCH 2/9] irq-remove: arch non-trivial Jeff Garzik
2007-10-19 16:54 ` Jeremy Fitzhardinge
2007-10-19 17:31 ` Jeff Garzik
2007-10-19 17:50 ` Jeff Garzik
2007-10-19 17:11 ` Eric W. Biederman
2007-10-19 17:16 ` Jeff Garzik
2007-10-19 19:38 ` Eric W. Biederman
2007-10-19 7:56 ` [PATCH 3/9] irq-remove: arch trivial Jeff Garzik
2007-10-19 7:56 ` [PATCH 4/9] irq-remove: driver non-trivial Jeff Garzik
2007-10-19 18:19 ` Eric W. Biederman
2007-10-19 18:36 ` Jeff Garzik
2007-10-19 7:57 ` [PATCH 5/9] irq-remove: net driver trivial Jeff Garzik
2007-10-19 7:57 ` [PATCH 6/9] irq-remove: sound " Jeff Garzik
2007-10-19 7:58 ` [PATCH 7/9] irq-remove: scsi " Jeff Garzik
2007-10-19 13:00 ` Salyzyn, Mark
2007-10-26 21:35 ` Andrew Morton
2007-10-26 21:47 ` Jeff Garzik
2007-10-26 23:50 ` Arjan van de Ven
2007-10-27 0:12 ` Jeff Garzik [this message]
2007-10-27 0:16 ` Arjan van de Ven
2007-10-27 0:37 ` Jeff Garzik
2007-10-27 5:31 ` Arjan van de Ven
2007-10-27 7:06 ` Jeff Garzik
2007-10-27 7:46 ` Eric W. Biederman
2007-10-27 14:17 ` Arjan van de Ven
2007-10-19 7:58 ` [PATCH 8/9] irq-remove: " Jeff Garzik
2007-10-19 7:59 ` [PATCH 9/9] irq-remove: misc fixes and cleanups Jeff Garzik
2007-10-19 14:53 ` [PATCH 0/9] Remove 'irq' argument from all irq handlers Thomas Gleixner
2007-10-19 18:38 ` Eric W. Biederman
2007-10-19 18:57 ` Jeff Garzik
2007-10-19 19:02 ` Jeff Garzik
2007-10-19 19:07 ` Ingo Molnar
2007-10-19 19:35 ` Eric W. Biederman
2007-10-19 19:41 ` Thomas Gleixner
2007-10-19 19:55 ` Jeff Garzik
2007-10-19 18:45 ` Mark Gross
2007-10-20 6:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47228278.8070505@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark_salyzyn@adaptec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.