From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1437EC4345F for ; Tue, 23 Apr 2024 14:59:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qFMfhM0AhUf+Ydn4Y4o518wfHVLX7mKw6XVtmuIoGEI=; b=hKg+p61YtV1DwY s22Zbj0A4xTW5HSsIcINZR7reqKVOQRLrA2CDs6XtKtr9e656qu01fIV79SVAgTbsonrKMuv88KP9 tChfTLfnExpZ+hV3Isr3HQRU/SwCoZC/NgF8uN4kjKwPruYZOyrzlxFtlft5F917MkEgigPIa4bf7 DdgZftE64/f7o3fy4FtO/nJ6DecMnQHmM0bue2lFxHRWBQYY07HLlB2K3l4l6tymvlIB6l8OpxGP0 z8bXLTprxXuuxnAL7lUoxO2fE6hSdXKnBZsx1alhl0G2TdQQhS9nfAY5SMmRaAJOwIdW55vmuWDiu hd1tMlK8IYBRaQUwx1/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzHcO-00000000Og8-0Zzb; Tue, 23 Apr 2024 14:59:36 +0000 Received: from out-171.mta0.migadu.com ([91.218.175.171]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rzHcJ-00000000OcS-3esb for linux-arm-kernel@lists.infradead.org; Tue, 23 Apr 2024 14:59:33 +0000 Message-ID: <472464bb-ae10-4452-aedf-a52b3eb8a25a@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1713884366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ccfCA2yriug7qqwYanAzAzrf5XnmP6204NXO919D7VA=; b=X51gGEygzLQf0O5Kzn5SPDhBrOWq0rKxZcATRaiTGC5LLiOmhIKKpQiL5HHziZF8Q9e6fZ 2UCkRCUJrMJ5MoEdR5ZWePLnpEMeqmSNytbsGZG85WLNN2ofAw8yXj6sYmI0PkeK3+Bgi8 bH2DldDQavPuAyFm+jPjjx2ArkqOk6E= Date: Tue, 23 Apr 2024 10:59:21 -0400 MIME-Version: 1.0 Subject: Re: [PATCH v3 00/13] drm: zynqmp_dp: IRQ cleanups and debugfs support To: Tomi Valkeinen Cc: David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michal Simek , Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org References: <20240422184553.3573009-1-sean.anderson@linux.dev> <5334a3cc-bcf9-4791-9ca9-1d0093899707@ideasonboard.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <5334a3cc-bcf9-4791-9ca9-1d0093899707@ideasonboard.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240423_075932_345693_B24A46D0 X-CRM114-Status: GOOD ( 17.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gNC8yMy8yNCAwOTozMywgVG9taSBWYWxrZWluZW4gd3JvdGU6Cj4gSGkgU2VhbiwKPiAKPiBP biAyMi8wNC8yMDI0IDIxOjQ1LCBTZWFuIEFuZGVyc29uIHdyb3RlOgo+PiBUaGlzIHNlcmllcyBj bGVhbnMgdXAgdGhlIHp5cW5tcF9kcCBJUlEgYW5kIGxvY2tpbmcgc2l0dWF0aW9uLiBPbmNlCj4+ IHRoYXQncyBkb25lLCBpdCBhZGRzIGRlYnVnZnMgc3VwcG9ydC4gVGhlIGludGVudCBpcyB0byBl bmFibGUgY29tcGxpYW5jZQo+PiB0ZXN0aW5nIG9yIHRvIGhlbHAgZGVidWcgc2lnbmFsLWludGVn cml0eSBpc3N1ZXMuCj4+Cj4+IExhc3QgdGltZSBJIGRpc2N1c3NlZCBjb252ZXJ0aW5nIHRoZSBI UEQgd29yayhzKSB0byBhIHRocmVhZGVkIElSUS4gSQo+PiBkaWQgbm90IGVuZCB1cCBkb2luZyB0 aGF0IGZvciB0aGlzIHNlcmllcyBzaW5jZSB0aGUgc3RlcHMgd291bGQgYmUKPj4KPj4gLSBBZGQg bG9ja2luZwo+PiAtIE1vdmUgbGluayByZXRyYWluaW5nIHRvIGEgd29yayBmdW5jdGlvbgo+PiAt IEhhcmRlbiB0aGUgSVJRCj4+IC0gTWVyZ2UgdGhlIHdvcmtzIGludG8gYSB0aHJlYWRlZCBJUlEg KG9taXR0ZWQpCj4+Cj4+IFdoaWNoIHdpdGggdGhlIGV4Y2VwdGlvbiBvZiB0aGUgZmluYWwgc3Rl cCBpcyB0aGUgc2FtZSBhcyBsZWF2aW5nIHRob3NlCj4+IHdvcmtzIGFzLWlzLiBDb252ZXJzaW9u IHRvIGEgdGhyZWFkZWQgSVJRIGNhbiBiZSBkb25lIGFzIGEgZm9sbG93LXVwLgo+IAo+IFdoYXQg aXMgdGhlIGJhc2UgZm9yIHRoaXMgc2VyaWVzPyBJJ20gaGF2aW5nIHRyb3VibGUgYXBwbHlpbmcg aXQuCj4gCj4gSSBtYW5hZ2VkIHRvIG1vc3RseSBhcHBseSBpdCwgYnV0IEkgc2VlIHRoZSBib2Fy ZCBoYW5nIHdoZW4gSSB1bmxvYWQgdGhlIG1vZHVsZXMuIEkgZGlkbid0IGRlYnVnIGl0IGFzIGl0 IG1pZ2h0IGFzIHdlbGwgYmUgY2F1c2VkIGJ5IG15IGNvbmZsaWN0IHJlc29sdXRpb24uCgpUaGUg YmFzZSBpcyB2Ni44LXJjMSwgYnV0IGl0IHNob3VsZCBwcm9iYWJseSBiZSB2Ni45LiBJIGNhbiBy ZWJhc2UgYW5kIHJlc2VuZC4KCi0tU2VhbgoKPj4gQ2hhbmdlcyBpbiB2MzoKPj4gLSBTdG9yZSBi YXNlIHBvaW50ZXJzIGluIHp5bnFtcF9kaXNwIGRpcmVjdGx5Cj4+IC0gRG9uJ3QgZGVsYXkgd29y awo+PiAtIENvbnZlcnQgdG8gYSBoYXJkIElSUQo+PiAtIFVzZSBBVVggSVJRcyBpbnN0ZWFkIG9m IHBvbGxpbmcKPj4gLSBUYWtlIGRwLT5sb2NrIGluIHp5bnFtcF9kcF9ocGRfd29ya19mdW5jCj4+ Cj4+IENoYW5nZXMgaW4gdjI6Cj4+IC0gRml4IGtlcm5lbGRvYwo+PiAtIFJlYXJyYW5nZSB6eW5x bXBfZHAgZm9yIGJldHRlciBwYWRkaW5nCj4+IC0gU3BsaXQgb2ZmIHRoZSBIUEQgSVJRIHdvcmsg aW50byBhbm90aGVyIGNvbW1pdAo+PiAtIEV4cGFuZCB0aGUgY29tbWl0IG1lc3NhZ2UKPj4gLSBE b2N1bWVudCBocGRfaXJxX3dvcmsKPj4gLSBEb2N1bWVudCBkZWJ1Z2ZzIGZpbGVzCj4+IC0gQWRk IGlnbm9yZV9hdXhfZXJyb3JzIGFuZCBpZ25vcmVfaHBkIGRlYnVnZnMgZmlsZXMgdG8gcmVwbGFj ZSBlYXJsaWVyCj4+IMKgwqAgaW1wbGljaXQgZnVuY3Rpb25hbGl0eQo+PiAtIEF0dGVtcHQgdG8g Zml4IHVucmVwcm9kdWNhYmxlLCBzcHVyaW91cyBidWlsZCB3YXJuaW5nCj4+IC0gRHJvcCAiT3B0 aW9uYWxseSBpZ25vcmUgRFBDRCBlcnJvcnMiIGluIGZhdm9yIG9mIGEgZGVidWdmcyBmaWxlCj4+ IMKgwqAgZGlyZWN0bHkgYWZmZWN0aW5nIHp5bnFtcF9kcF9hdXhfdHJhbnNmZXIuCj4+Cj4+IFNl YW4gQW5kZXJzb24gKDEzKToKPj4gwqDCoCBkcm06IHhsbng6IFN0b3JlIGJhc2UgcG9pbnRlcnMg aW4genlucW1wX2Rpc3AgZGlyZWN0bHkKPj4gwqDCoCBkcm06IHhsbng6IEZpeCBrZXJuZWxkb2MK Pj4gwqDCoCBkcm06IHp5bnFtcF9kcDogRG93bmdyYWRlIGxvZyBsZXZlbCBmb3IgYXV4IHJldHJp ZXMgbWVzc2FnZQo+PiDCoMKgIGRybTogenlucW1wX2RwOiBBZGp1c3QgdHJhaW5pbmcgdmFsdWVz IHBlci1sYW5lCj4+IMKgwqAgZHJtOiB6eW5xbXBfZHA6IFJlYXJyYW5nZSB6eW5xbXBfZHAgZm9y IGJldHRlciBwYWRkaW5nCj4+IMKgwqAgZHJtOiB6eW5xbXBfZHA6IERvbid0IGRlbGF5IHdvcmsK Pj4gwqDCoCBkcm06IHp5bnFtcF9kcDogQWRkIGxvY2tpbmcKPj4gwqDCoCBkcm06IHp5bnFtcF9k cDogRG9uJ3QgcmV0cmFpbiB0aGUgbGluayBpbiBvdXIgSVJRCj4+IMKgwqAgZHJtOiB6eW5xbXBf ZHA6IENvbnZlcnQgdG8gYSBoYXJkIElSUQo+PiDCoMKgIGRybTogenlucW1wX2RwOiBVc2UgQVVY IElSUXMgaW5zdGVhZCBvZiBwb2xsaW5nCj4+IMKgwqAgZHJtOiB6eW5xbXBfZHA6IFNwbGl0IG9m ZiBzZXZlcmFsIGhlbHBlciBmdW5jdGlvbnMKPj4gwqDCoCBkcm06IHp5bnFtcF9kcDogVGFrZSBk cC0+bG9jayBpbiB6eW5xbXBfZHBfaHBkX3dvcmtfZnVuYwo+PiDCoMKgIGRybTogenlucW1wX2Rw OiBBZGQgZGVidWdmcyBpbnRlcmZhY2UgZm9yIGNvbXBsaWFuY2UgdGVzdGluZwo+Pgo+PiDCoCBE b2N1bWVudGF0aW9uL2dwdS9kcml2ZXJzLnJzdMKgwqDCoMKgwqDCoCB8wqDCoCAxICsKPj4gwqAg RG9jdW1lbnRhdGlvbi9ncHUvenlucW1wLnJzdMKgwqDCoMKgwqDCoMKgIHwgMTQ5ICsrKysrCj4+ IMKgIE1BSU5UQUlORVJTwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIHzCoMKgIDEgKwo+PiDCoCBkcml2ZXJzL2dwdS9kcm0veGxueC96eW5xbXBfZGlzcC5j wqAgfMKgIDQ0ICstCj4+IMKgIGRyaXZlcnMvZ3B1L2RybS94bG54L3p5bnFtcF9kcC5jwqDCoMKg IHwgOTA5ICsrKysrKysrKysrKysrKysrKysrKysrKystLS0KPj4gwqAgZHJpdmVycy9ncHUvZHJt L3hsbngvenlucW1wX2Rwc3ViLmggfMKgwqAgMSArCj4+IMKgIGRyaXZlcnMvZ3B1L2RybS94bG54 L3p5bnFtcF9rbXMuaMKgwqAgfMKgwqAgNCArLQo+PiDCoCA3IGZpbGVzIGNoYW5nZWQsIDEwMDAg aW5zZXJ0aW9ucygrKSwgMTA5IGRlbGV0aW9ucygtKQo+PiDCoCBjcmVhdGUgbW9kZSAxMDA2NDQg RG9jdW1lbnRhdGlvbi9ncHUvenlucW1wLnJzdAo+Pgo+IAoKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E649AC4345F for ; Tue, 23 Apr 2024 14:59:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 19CDF113430; Tue, 23 Apr 2024 14:59:32 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=linux.dev header.i=@linux.dev header.b="X51gGEyg"; dkim-atps=neutral Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1C49C113430 for ; Tue, 23 Apr 2024 14:59:29 +0000 (UTC) Message-ID: <472464bb-ae10-4452-aedf-a52b3eb8a25a@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1713884366; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ccfCA2yriug7qqwYanAzAzrf5XnmP6204NXO919D7VA=; b=X51gGEygzLQf0O5Kzn5SPDhBrOWq0rKxZcATRaiTGC5LLiOmhIKKpQiL5HHziZF8Q9e6fZ 2UCkRCUJrMJ5MoEdR5ZWePLnpEMeqmSNytbsGZG85WLNN2ofAw8yXj6sYmI0PkeK3+Bgi8 bH2DldDQavPuAyFm+jPjjx2ArkqOk6E= Date: Tue, 23 Apr 2024 10:59:21 -0400 MIME-Version: 1.0 Subject: Re: [PATCH v3 00/13] drm: zynqmp_dp: IRQ cleanups and debugfs support To: Tomi Valkeinen Cc: David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michal Simek , Laurent Pinchart , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org References: <20240422184553.3573009-1-sean.anderson@linux.dev> <5334a3cc-bcf9-4791-9ca9-1d0093899707@ideasonboard.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <5334a3cc-bcf9-4791-9ca9-1d0093899707@ideasonboard.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 4/23/24 09:33, Tomi Valkeinen wrote: > Hi Sean, > > On 22/04/2024 21:45, Sean Anderson wrote: >> This series cleans up the zyqnmp_dp IRQ and locking situation. Once >> that's done, it adds debugfs support. The intent is to enable compliance >> testing or to help debug signal-integrity issues. >> >> Last time I discussed converting the HPD work(s) to a threaded IRQ. I >> did not end up doing that for this series since the steps would be >> >> - Add locking >> - Move link retraining to a work function >> - Harden the IRQ >> - Merge the works into a threaded IRQ (omitted) >> >> Which with the exception of the final step is the same as leaving those >> works as-is. Conversion to a threaded IRQ can be done as a follow-up. > > What is the base for this series? I'm having trouble applying it. > > I managed to mostly apply it, but I see the board hang when I unload the modules. I didn't debug it as it might as well be caused by my conflict resolution. The base is v6.8-rc1, but it should probably be v6.9. I can rebase and resend. --Sean >> Changes in v3: >> - Store base pointers in zynqmp_disp directly >> - Don't delay work >> - Convert to a hard IRQ >> - Use AUX IRQs instead of polling >> - Take dp->lock in zynqmp_dp_hpd_work_func >> >> Changes in v2: >> - Fix kerneldoc >> - Rearrange zynqmp_dp for better padding >> - Split off the HPD IRQ work into another commit >> - Expand the commit message >> - Document hpd_irq_work >> - Document debugfs files >> - Add ignore_aux_errors and ignore_hpd debugfs files to replace earlier >>    implicit functionality >> - Attempt to fix unreproducable, spurious build warning >> - Drop "Optionally ignore DPCD errors" in favor of a debugfs file >>    directly affecting zynqmp_dp_aux_transfer. >> >> Sean Anderson (13): >>    drm: xlnx: Store base pointers in zynqmp_disp directly >>    drm: xlnx: Fix kerneldoc >>    drm: zynqmp_dp: Downgrade log level for aux retries message >>    drm: zynqmp_dp: Adjust training values per-lane >>    drm: zynqmp_dp: Rearrange zynqmp_dp for better padding >>    drm: zynqmp_dp: Don't delay work >>    drm: zynqmp_dp: Add locking >>    drm: zynqmp_dp: Don't retrain the link in our IRQ >>    drm: zynqmp_dp: Convert to a hard IRQ >>    drm: zynqmp_dp: Use AUX IRQs instead of polling >>    drm: zynqmp_dp: Split off several helper functions >>    drm: zynqmp_dp: Take dp->lock in zynqmp_dp_hpd_work_func >>    drm: zynqmp_dp: Add debugfs interface for compliance testing >> >>   Documentation/gpu/drivers.rst       |   1 + >>   Documentation/gpu/zynqmp.rst        | 149 +++++ >>   MAINTAINERS                         |   1 + >>   drivers/gpu/drm/xlnx/zynqmp_disp.c  |  44 +- >>   drivers/gpu/drm/xlnx/zynqmp_dp.c    | 909 +++++++++++++++++++++++++--- >>   drivers/gpu/drm/xlnx/zynqmp_dpsub.h |   1 + >>   drivers/gpu/drm/xlnx/zynqmp_kms.h   |   4 +- >>   7 files changed, 1000 insertions(+), 109 deletions(-) >>   create mode 100644 Documentation/gpu/zynqmp.rst >> >