From: Vasily Averin <vvs@sw.ru>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devel@openvz.org
Cc: Jens Axboe <jens.axboe@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: i2o: CONFIG_DEBUG_SG compilation fixed
Date: Mon, 29 Oct 2007 09:32:13 +0300 [thread overview]
Message-ID: <47257E6D.30403@sw.ru> (raw)
i2o crashed when CONFIG_DEBUG_SG is enabled because i2o_block_request structure
includes array of scatterlists that should be initialised
Signed-off-by: Vasily Averin <vvs@sw.ru>
--- a/drivers/message/i2o/i2o_block.c
+++ b/drivers/message/i2o/i2o_block.c
@@ -1137,6 +1137,18 @@ static struct i2o_driver i2o_block_driver = {
*
* Returns 0 on success or negative error code on failure.
*/
+
+#ifdef CONFIG_DEBUG_SG
+static void i2o_block_req_ctor(struct kmem_cache *cachep, void *objp) {
+ sg_init_table(((struct i2o_block_request *)(objp))->sg_table,
+ I2O_MAX_PHYS_SEGMENTS);
+}
+
+#define I2O_BLK_CTOR &i2o_block_req_ctor
+#else
+#define I2O_BLK_CTOR NULL
+#endif
+
static int __init i2o_block_init(void)
{
int rc;
@@ -1147,7 +1159,7 @@ static int __init i2o_block_init(void)
/* Allocate request mempool and slab */
size = sizeof(struct i2o_block_request);
i2o_blk_req_pool.slab = kmem_cache_create("i2o_block_req", size, 0,
- SLAB_HWCACHE_ALIGN, NULL);
+ SLAB_HWCACHE_ALIGN, I2O_BLK_CTOR);
if (!i2o_blk_req_pool.slab) {
osm_err("can't init request slab\n");
rc = -ENOMEM;
next reply other threads:[~2007-10-29 6:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 6:32 Vasily Averin [this message]
2007-10-29 8:58 ` i2o: CONFIG_DEBUG_SG compilation fixed Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47257E6D.30403@sw.ru \
--to=vvs@sw.ru \
--cc=akpm@linux-foundation.org \
--cc=devel@openvz.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.