From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-ide@vger.kernel.org
Subject: Re: [PATCH #upstream 1/2] libata: relocate forcing PIO0 on reset
Date: Mon, 29 Oct 2007 06:22:22 -0400 [thread overview]
Message-ID: <4725B45E.6070003@garzik.org> (raw)
In-Reply-To: <20071029074109.GO11853@htj.dyndns.org>
Tejun Heo wrote:
> Forcing PIO0 on reset was done inside ata_bus_softreset(), which is a
> bit out of place as it should be applied to all resets - hard, soft
> and implementation which don't use ata_bus_softreset(). Relocate it
> such that...
>
> * For new EH, it's done in ata_eh_reset() before calling prereset.
>
> * For old EH, it's done before calling ap->ops->phy_reset() in
> ata_bus_probe().
>
> This makes PIO0 forced after all resets. Another difference is that
> reset itself is done after PIO0 is forced.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
applied 1-2 to #upstream-fixes, after renaming existing #upstream to
#upstream-fixes (thereby assuring those previous changesets will go
upstream sooner)
next prev parent reply other threads:[~2007-10-29 10:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 7:41 [PATCH #upstream 1/2] libata: relocate forcing PIO0 on reset Tejun Heo
2007-10-29 7:45 ` [PATCH #upstream 2/2] libata: no need to speed down if already at PIO0 Tejun Heo
2007-10-29 8:35 ` Alan Cox
2007-10-29 10:22 ` Jeff Garzik [this message]
2007-10-30 21:25 ` [PATCH #upstream 1/2] libata: relocate forcing PIO0 on reset Chuck Ebbert
2007-10-31 0:13 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4725B45E.6070003@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.