From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: Alex Tomas <bzzz.tomas@gmail.com>
Cc: Andreas Dilger <adilger@clusterfs.com>,
Eric Sandeen <sandeen@redhat.com>,
Valerie Clement <valerie.clement@bull.net>,
Theodore Tso <tytso@mit.edu>, Mingming Cao <cmm@us.ibm.com>,
linux-ext4 <linux-ext4@vger.kernel.org>
Subject: Re: delalloc and reservation.
Date: Mon, 29 Oct 2007 20:03:23 +0530 [thread overview]
Message-ID: <4725EF33.7050804@linux.vnet.ibm.com> (raw)
In-Reply-To: <4725F8E6.2050500@gmail.com>
Alex Tomas wrote:
> Hi,
>
> could you try the patch attached. it should fix the issue. the idea
> was to align requests in order to help raid5-like setups. but somewhere
> I lost one bit in mballoc: it should pre-allocate all crossed stripes,
> but it didn't.
>
> as for discard, lustre doesn't use open/close for data, so discard-on-close
> makes zero sense in our case. I'm not very positive whether we need to
> drop preallocation on file close in case of delayed allocation as writeback
> can be started while file is open and finish after close(2).
>
>
mballoc by default doesn't give the particular layout only if i force small
size to use inode preallocation i am hitting the problem. ie to change the
below line in ext4_mb_group_or_file
if (ac->ac_o_ex.fe_len >= sbi->s_mb_small_req)
to
if (ac->ac_o_ex.fe_len <= sbi->s_mb_small_req)
Do you want to test the patch with this change ?
We are observing the problem with delalloc and nomballoc.
-aneesh
next prev parent reply other threads:[~2007-10-29 15:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 10:00 delalloc and reservation Aneesh Kumar K.V
2007-10-29 11:07 ` Aneesh Kumar K.V
2007-10-30 11:01 ` [RFC/PATCH] ext4: Clear the reservation window correctly with delayed allocation Aneesh Kumar K.V
2007-10-30 11:24 ` Alex Tomas
2007-10-29 15:14 ` delalloc and reservation Alex Tomas
2007-10-29 14:33 ` Aneesh Kumar K.V [this message]
2007-10-29 15:44 ` Alex Tomas
2007-10-29 15:19 ` Aneesh Kumar K.V
2007-10-29 16:26 ` Alex Tomas
-- strict thread matches above, loose matches on Subject: below --
2007-10-29 14:24 Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4725EF33.7050804@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=adilger@clusterfs.com \
--cc=bzzz.tomas@gmail.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
--cc=valerie.clement@bull.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.