From: Jeff Garzik <jeff@garzik.org>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH 2/2] netdrvr/ibmlana: move away from legacy MCA API
Date: Mon, 29 Oct 2007 15:41:34 -0400 [thread overview]
Message-ID: <4726376E.3080608@garzik.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0710292039020.26070@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> On Oct 29 2007 15:33, Jeff Garzik wrote:
>> +#if 0 /* info available elsewhere, but this is kept for reference */
>
> It is available in the git history, yes, is it still needed for reference?
it's there to see if anyone complains at its removal :)
>> +static short ibmlana_adapter_ids[] __initdata = {
>> + IBM_LANA_ID,
>> + 0x0000
>> +};
>> +
>> +static char *ibmlana_adapter_names[] __initdata = {
>> + "IBM LAN Adapter/A",
>> + NULL
>> +};
>
> Can this be const?
Not with the initdata marker, no.
Jeff
prev parent reply other threads:[~2007-10-29 19:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 19:33 [PATCH 1/2] netdrvr/ibmlana: modularization cleanup Jeff Garzik
2007-10-29 19:33 ` [PATCH 2/2] netdrvr/ibmlana: move away from legacy MCA API Jeff Garzik
2007-10-29 19:39 ` Jan Engelhardt
2007-10-29 19:41 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4726376E.3080608@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.