All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Massimo Di Nitto <fabbione@ubuntu.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [RFC - PATCH] gfs2/gfs kernel: warn if mount/umount helpers are missing
Date: Mon, 29 Oct 2007 22:36:18 +0100	[thread overview]
Message-ID: <47265252.4040608@ubuntu.com> (raw)


Hi guys,

I have recently been bitten by a bad installation where the either the mount or
the umount helper was not installed properly in the system.

After discussing a bit on IRC with David, we agreed that the best approach to
warn the user about this situation was a kernel message.

Looking in the default set of options that mount.gfs* sets there is at least
hostdata that is mandatory.

The patch in attachment verifies that hostdata is set after parsing all the
options and if empty will warn the users that the helpers might not have been
installed properly.

The same method could be applied to gfs2 but at the moment it OOPS'es on my test
cluster and I can't verify it.

Please apply or ACK and I will apply to CVS HEAD.

Thanks
Fabio

-- 
I'm going to make him an offer he can't refuse.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: foo.diff
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20071029/8a46c2bd/attachment.ksh>

                 reply	other threads:[~2007-10-29 21:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47265252.4040608@ubuntu.com \
    --to=fabbione@ubuntu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.