From: Jeff Garzik <jeff@garzik.org>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
hch@infradead.org, linux-kernel@vger.kernel.org,
Sam Ravnborg <sam@ravnborg.org>,
Jens Axboe <jens.axboe@oracle.com>,
Prasanna S Panchamukhi <prasanna@in.ibm.com>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <pzijlstr@redhat.com>,
Philippe Elie <phil.el@wanadoo.fr>,
Linus Torvalds <torvalds@linux-foundation.org>,
"William L. Irwin" <wli@holomorphy.com>,
Arjan van de Ven <arjan@infradead.org>,
Christoph Lameter <christoph@lameter.com>,
Valdis.Kletnieks@vt.edu
Subject: Re: [RFC] Create instrumentation directory (git repository)
Date: Mon, 29 Oct 2007 20:47:17 -0400 [thread overview]
Message-ID: <47267F15.9090302@garzik.org> (raw)
In-Reply-To: <20071029233515.GA19413@Krystal>
Mathieu Desnoyers wrote:
> I see no good reason to have so many different adhoc instrumentation
> mechanisms for profiling (sched, vm, oprofile) and tracing (blktrace,
> suspend/resume tracing) all over the place. Merging them in a single
> directory seems like a good step towards a more generic
> instrumentation/profiling/tracing infrastructure.
Moving files about in directories should be at the /lowest/ end of the
priority scale. It makes diffs unreadable, file histories and diffing
difficult, and a host of other problems.
Please solve the /real/ problems, and then come back and clean up the
file structure after that is done. Massive file renaming to satisfying
some imagined future everything-is-golden scheme is the /last/ step. It
is the last step taken because the previous steps inevitably give you
guidance that you otherwise would not have had at the start of the task.
When I try to diff between old and new alpha oprofile code, I really
want to know that the reason why diffing is a pain in the ass is more
than "it seemed like a good first step."
> Back to "profile" and "probes" directory names, they might be short, but
> they do not represent the whole markup-profiling-tracing trio,
> "profile" lacks the tracing part and "probe" lacks the markup part.
You can always add more letters (and words) to even reach the desired
level of specificity. That does nothing to help readability though.
Anyway, it should be clear from existing precedent -- existing pathnames
-- that "instrumentation" is too long, and really IMO too vague anyway.
Jeff
next prev parent reply other threads:[~2007-10-30 0:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 21:51 [RFC] Create instrumentation directory (git repository) Mathieu Desnoyers
2007-10-29 22:47 ` Randy Dunlap
2007-10-29 22:54 ` Jeff Garzik
2007-10-29 23:04 ` Mathieu Desnoyers
2007-10-29 23:08 ` Jeff Garzik
2007-10-29 23:35 ` Mathieu Desnoyers
2007-10-30 0:47 ` Jeff Garzik [this message]
2007-10-30 1:38 ` Mathieu Desnoyers
2007-10-30 9:13 ` Arnaldo Carvalho de Melo
2007-10-30 17:24 ` [RFC] Create kinst/ or ki/ directory ? Mathieu Desnoyers
2007-10-30 17:49 ` Peter Zijlstra
2007-10-30 17:50 ` Linus Torvalds
2007-10-30 17:58 ` Christoph Hellwig
2007-10-30 18:56 ` Mathieu Desnoyers
2007-10-30 19:25 ` Linus Torvalds
2007-10-30 20:40 ` Mathieu Desnoyers
2007-10-31 15:48 ` Frank Ch. Eigler
2007-10-31 16:29 ` Arjan van de Ven
2007-10-31 19:05 ` Frank Ch. Eigler
2007-10-31 19:49 ` Arjan van de Ven
2007-10-31 16:36 ` Mathieu Desnoyers
2007-10-31 19:29 ` Frank Ch. Eigler
2007-10-30 21:46 ` Sam Ravnborg
2007-10-29 23:20 ` [RFC] Create instrumentation directory (git repository) Christoph Lameter
2007-10-29 23:40 ` Mathieu Desnoyers
2007-10-29 23:45 ` Christoph Lameter
2007-10-30 0:51 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47267F15.9090302@garzik.org \
--to=jeff@garzik.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=arjan@infradead.org \
--cc=christoph@lameter.com \
--cc=davem@davemloft.net \
--cc=hch@infradead.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@redhat.com \
--cc=phil.el@wanadoo.fr \
--cc=prasanna@in.ibm.com \
--cc=pzijlstr@redhat.com \
--cc=rdunlap@xenotime.net \
--cc=sam@ravnborg.org \
--cc=torvalds@linux-foundation.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.