From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Akio Takebe <takebe_akio-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [Patch][RFC] fix make rpm
Date: Tue, 30 Oct 2007 13:59:46 +0200 [thread overview]
Message-ID: <47271CB2.1020503@qumranet.com> (raw)
In-Reply-To: <CBC81ADDCF7D33takebe_akio-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
Akio Takebe wrote:
> Hi,
>
>
Hi!
> This patch fix "make rpm".
> When I used the rpm option, I got some error.
> So I fixed it, but it is a just sample?
>
>
'make rpm' works for me on F7 (after I fixed fallout from the libkvm
separation patch). What distribution did you run it on? What error did
you get?
I think we can't treat it as more than a sample because we can't expect
it to work everywhere (e.g. debian). But i will accept patches to
improve it.
> What do you think about it?
>
> Signed-off-by: Akio Takebe <takebe_akio-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
> -/usr/kvm
> +%dir /usr/kvm
> +%dir /usr/kvm/bin
> +/usr/kvm/bin/qemu-img
> +/usr/kvm/bin/qemu-system-x86_64
> +%dir /usr/kvm/share
> +%dir /usr/kvm/share/qemu
> +/usr/kvm/share/qemu/bios.bin
> +%dir /usr/kvm/share/qemu/keymaps
> +/usr/kvm/share/qemu/keymaps/ar
> +/usr/kvm/share/qemu/keymaps/common
> +/usr/kvm/share/qemu/keymaps/da
> +/usr/kvm/share/qemu/keymaps/de
> +/usr/kvm/share/qemu/keymaps/de-ch
> +/usr/kvm/share/qemu/keymaps/en-gb
> +/usr/kvm/share/qemu/keymaps/en-us
> +/usr/kvm/share/qemu/keymaps/es
> +/usr/kvm/share/qemu/keymaps/et
> +/usr/kvm/share/qemu/keymaps/fi
> +/usr/kvm/share/qemu/keymaps/fo
> +/usr/kvm/share/qemu/keymaps/fr
> +/usr/kvm/share/qemu/keymaps/fr-be
> +/usr/kvm/share/qemu/keymaps/fr-ca
> +/usr/kvm/share/qemu/keymaps/fr-ch
> +/usr/kvm/share/qemu/keymaps/hr
> +/usr/kvm/share/qemu/keymaps/hu
> +/usr/kvm/share/qemu/keymaps/is
> +/usr/kvm/share/qemu/keymaps/it
> +/usr/kvm/share/qemu/keymaps/ja
> +/usr/kvm/share/qemu/keymaps/lt
> +/usr/kvm/share/qemu/keymaps/lv
> +/usr/kvm/share/qemu/keymaps/mk
> +/usr/kvm/share/qemu/keymaps/modifiers
> +/usr/kvm/share/qemu/keymaps/nl
> +/usr/kvm/share/qemu/keymaps/nl-be
> +/usr/kvm/share/qemu/keymaps/no
> +/usr/kvm/share/qemu/keymaps/pl
> +/usr/kvm/share/qemu/keymaps/pt
> +/usr/kvm/share/qemu/keymaps/pt-br
> +/usr/kvm/share/qemu/keymaps/ru
> +/usr/kvm/share/qemu/keymaps/sl
> +/usr/kvm/share/qemu/keymaps/sv
> +/usr/kvm/share/qemu/keymaps/th
> +/usr/kvm/share/qemu/keymaps/tr
> +/usr/kvm/share/qemu/openbios-sparc32
> +/usr/kvm/share/qemu/ppc_rom.bin
> +/usr/kvm/share/qemu/pxe-ne2k_pci.bin
> +/usr/kvm/share/qemu/pxe-pcnet.bin
> +/usr/kvm/share/qemu/pxe-rtl8139.bin
> +/usr/kvm/share/qemu/vgabios-cirrus.bin
> +/usr/kvm/share/qemu/vgabios.bin
> +/usr/kvm/share/qemu/video.x
> +%dir /lib/modules/%{uname}/extra
> +/lib/modules/%{uname}/extra/kvm.ko
> +/lib/modules/%{uname}/extra/kvm-intel.ko
> +/lib/modules/%{uname}/extra/kvm-amd.ko
> %changelog
>
>
Why is this change necessary? Doesn't '/usr/kvm' work? This way, every
time qemu adds a file we have to update the rpm spec.
--
Any sufficiently difficult bug is indistinguishable from a feature.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-10-30 11:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 10:15 [Patch][RFC] fix make rpm Akio Takebe
[not found] ` <CBC81ADDCF7D33takebe_akio-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2007-10-30 11:59 ` Avi Kivity [this message]
[not found] ` <47271CB2.1020503-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-10-30 12:16 ` Akio Takebe
[not found] ` <CEC81AEEA48120takebe_akio-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2007-10-30 12:24 ` Avi Kivity
2007-10-30 15:10 ` Hollis Blanchard
2007-10-31 0:39 ` Avi Kivity
[not found] ` <4727CEDF.8060304-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-10-31 15:25 ` Hollis Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47271CB2.1020503@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=takebe_akio-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.