From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: Questions about scsi.c Date: Tue, 30 Oct 2007 08:34:50 -0400 Message-ID: <472724EA.3050502@pobox.com> References: <200710250606.03301.rob@landley.net> <200710251325.37586.rob@landley.net> <20071025103241.546b35ec.rdunlap@xenotime.net> <200710251640.35758.rob@landley.net> <20071025134926.4d209584.rdunlap@xenotime.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:35367 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751574AbXJ3Mex (ORCPT ); Tue, 30 Oct 2007 08:34:53 -0400 In-Reply-To: <20071025134926.4d209584.rdunlap@xenotime.net> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Randy Dunlap Cc: Rob Landley , linux-scsi@vger.kernel.org Randy Dunlap wrote: > On Thu, 25 Oct 2007 16:40:35 -0500 Rob Landley wrote: > >> On Thursday 25 October 2007 12:32:41 pm Randy Dunlap wrote: >>>> Entirely possible I'm doing something wrong: >>>> >>>> >>>> include/scsi/scsi_device.h >>>> >>>> >>>> !Einclude/scsi/scsi_device.h >>>> >>> !E is for exported symbols and that file has none. >>> USe !I instead. >> So how do I handle a case like drivers/ata/libata-core.c which has >> EXPORT_SYMBOL() calls for functions that live in (and are documented in) >> other files, such as ata_scsi_ioctl() in drivers/ata/libata-scsi.c? > > I don't see ata_scsi_ioctl() documented at all. Are you looking at > a newer tree than I am? (i'm using 2.6.24-rc1) > > Long-term answer is that we prefer EXPORT_SYMBOL() to be used > just under the function that is being exported. In this case, > the maintainer may be disagreeing with that. [cc-ed] > > Short-term answer is to use !Isource_filename_where_kernel_doc_is > as though it's not EXPORTed. I think. Yeah I tended to prefer that all exports be in one place, rather than scattered around and difficult to evaluate en masse :) Jeff