All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@mvista.com>
To: Felipe Balbi <felipebalbi@users.sourceforge.net>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] ARM: OMAP: compile-fixes for PM debug
Date: Tue, 30 Oct 2007 06:18:38 -0700	[thread overview]
Message-ID: <47272F2E.2080608@mvista.com> (raw)
In-Reply-To: <31e679430710300514mb809381y72a15edef48da6ad@mail.gmail.com>

Felipe Balbi wrote:
> Hi,
> 
> On 10/30/07, Kevin Hilman <khilman@mvista.com> wrote:
>> Fix compile problems in omap2_pm_debug()
>>
>> Signed-off-by: Kevin Hilman <khilman@mvista.com>
>> ---
>>  arch/arm/mach-omap2/pm.c |    6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> Index: dev/arch/arm/mach-omap2/pm.c
>> ===================================================================
>> --- dev.orig/arch/arm/mach-omap2/pm.c
>> +++ dev/arch/arm/mach-omap2/pm.c
>> @@ -240,15 +240,15 @@ static void omap2_pm_dump(int mode, int
>>  #endif
>>  #if 0
>>                 DUMP_CM_MOD_REG(CORE_MOD, CM_FCLKEN1);
>> -               DUMP_CM_MOD_REG(CORE_MOD, CM_FCLKEN2);
>> +               DUMP_CM_MOD_REG(CORE_MOD, OMAP24XX_CM_FCLKEN2);
> 
> Are you sure this is needed? This code is commented.
> 

It is needed when the code is uncommented, which is used for debugging
suspend/resume and sleep-when-idle.

Kevin

  reply	other threads:[~2007-10-30 13:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-30 11:40 [PATCH] ARM: OMAP: compile-fixes for PM debug Kevin Hilman
2007-10-30 12:14 ` Felipe Balbi
2007-10-30 13:18   ` Kevin Hilman [this message]
2007-10-30 13:53     ` Felipe Balbi
2007-11-01  8:53       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47272F2E.2080608@mvista.com \
    --to=khilman@mvista.com \
    --cc=felipebalbi@users.sourceforge.net \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.