From: Jeff Garzik <jeff@garzik.org>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: linux-ide@vger.kernel.org, Alexander Sabourenkov <screwdriver@lxnt.info>
Subject: Re: [PATCH 2.6.24-rc1 1/2] sata_promise: ASIC PRD table bug workaround, take 2
Date: Tue, 30 Oct 2007 09:28:12 -0400 [thread overview]
Message-ID: <4727316C.8060004@garzik.org> (raw)
In-Reply-To: <200710301320.l9UDKndW028161@harpo.it.uu.se>
Mikael Pettersson wrote:
> Second-generation Promise SATA controllers have an ASIC bug
> which can trigger if the last PRD entry is larger than 164 bytes,
> resulting in intermittent errors and possible data corruption.
>
> Work around this by replacing calls to ata_qc_prep() with a
> private version that fills the PRD, checks the size of the
> last entry, and if necessary splits it to avoid the bug.
> Also reduce sg_tablesize by 1 to accommodate the new entry.
>
> Tested on the second-generation SATA300 TX4 and SATA300 TX2plus,
> and the first-generation PDC20378.
>
> Thanks to Alexander Sabourenkov for verifying the bug by
> studying the vendor driver, and for writing the initial patch
> upon which this one is based.
>
> Signed-off-by: Mikael Pettersson <mikpe@it.uu.se>
> --
> Changes since previous version:
> * use new PDC_MAX_PRD constant to initialise sg_tablesize
>
> drivers/ata/sata_promise.c | 87 ++++++++++++++++++++++++++++++++++++++++++---
> 1 files changed, 83 insertions(+), 4 deletions(-)
applies 1-2 to #upstream-fixes
prev parent reply other threads:[~2007-10-30 13:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 13:20 [PATCH 2.6.24-rc1 1/2] sata_promise: ASIC PRD table bug workaround, take 2 Mikael Pettersson
2007-10-30 13:28 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4727316C.8060004@garzik.org \
--to=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=mikpe@it.uu.se \
--cc=screwdriver@lxnt.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.