All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: paulmck@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	rusty@au1.ibm.com, zhaojingmin@users.sourceforge.net,
	davem@davemloft.net
Subject: Re: [PATCH] nf_nat_h323.c unneeded rcu_dereference() calls
Date: Tue, 30 Oct 2007 15:06:20 +0100	[thread overview]
Message-ID: <47273A5C.7040909@trash.net> (raw)
In-Reply-To: <20071029210618.GA4200@linux.vnet.ibm.com>

Paul E. McKenney wrote:
> Hello!
> 
> While reviewing rcu_dereference() uses, I came across a number of cases
> where I couldn't see how the rcu_dereference() helped.  One class of
> cases is where the variable is never subsequently dereferenced, so that
> patches like the following one would be appropriate.
> 
> So, what am I missing here?


Nothing, it was mainly intended as documentation that the hooks are
protected by RCU. I agree that its probably more confusing this way
since we're not even in a rcu_read_lock protected section.

I've queued a patch to remove them all.

  reply	other threads:[~2007-10-30 14:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-29 21:06 [PATCH] nf_nat_h323.c unneeded rcu_dereference() calls Paul E. McKenney
2007-10-30 14:06 ` Patrick McHardy [this message]
2007-10-30 15:37   ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47273A5C.7040909@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=rusty@au1.ibm.com \
    --cc=zhaojingmin@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.