From: Patrick McHardy <kaber@trash.net>
To: Alexey Dobriyan <adobriyan@sw.ru>
Cc: Stephen Hemminger <shemminger@linux-foundation.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] Convert /proc/net/ipv6_route to seq_file interface
Date: Tue, 30 Oct 2007 16:37:09 +0100 [thread overview]
Message-ID: <47274FA5.8070902@trash.net> (raw)
In-Reply-To: <20071030083043.47f5def3@freepuppy.rosehill>
Stephen Hemminger wrote:
> On Tue, 30 Oct 2007 16:11:47 +0300
> Alexey Dobriyan <adobriyan@sw.ru> wrote:
>>
>> +static const struct file_operations ipv6_route_proc_fops = {
>> + .open = ipv6_route_open,
>> + .read = seq_read,
>> + .llseek = seq_lseek,
>> + .release = single_release,
>> +};
>> +
>
> This needs
> .owner = THIS_MODULE,
Your ip_queue conversion patch was also missing this, I've
fixed it up.
next prev parent reply other threads:[~2007-10-30 15:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 13:11 [PATCH 1/2] Convert /proc/net/ipv6_route to seq_file interface Alexey Dobriyan
2007-10-30 13:35 ` Benjamin Thery
2007-10-30 13:46 ` Benjamin Thery
2007-10-30 15:30 ` Stephen Hemminger
2007-10-30 15:37 ` Patrick McHardy [this message]
2007-10-30 22:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47274FA5.8070902@trash.net \
--to=kaber@trash.net \
--cc=adobriyan@sw.ru \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.