Re: [PATCH] ARM: OMAP: Fix usb gadget related compile errors and typo

[Dirk Behme <dirk.behme@googlemail.com>]

David Brownell wrote:
>>- * gadget_is_dualspeed - return true iff the hardware handles high speed
>>+ * gadget_is_dualspeed - return true if the hardware handles high speed
> 
> Not a typo; "iff" == "if and only if".  NAK to that part.

Sorry. Sometimes its hard to be a non-native speaker ;)

> Re the other, please make those parts match what's upstream;

Creating the patch ~3 hours after Tonys "update linux-omap to mainline 
tree" I assumed OMAP git was in sync with mainline.

> I think you added extra parens.

Yes. I tried to fix this compilation error:

   CC      drivers/usb/gadget/omap_udc.o
drivers/usb/gadget/omap_udc.c: In function 'pullup_enable':
drivers/usb/gadget/omap_udc.c:1244: error: incompatible type for 
argument 1 of 'gadget_is_otg'
drivers/usb/gadget/omap_udc.c: In function 'pullup_disable':
drivers/usb/gadget/omap_udc.c:1251: error: incompatible type for 
argument 1 of 'gadget_is_otg'
drivers/usb/gadget/omap_udc.c: In function 'update_otg':
drivers/usb/gadget/omap_udc.c:1389: error: incompatible type for 
argument 1 of 'gadget_is_otg'

gadget_is_otg() is defined as

static inline int gadget_is_otg(struct usb_gadget *g) { ...

and the call is

gadget_is_otg(udc->gadget)

Which fix do you propose for this?

Best regards

Dirk