From: Daniel Lezcano <dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
To: Dave Hansen <haveblue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: Containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org,
"Eric W. Biederman"
<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH][NETNS] release net when pneigh_lookup fails
Date: Tue, 30 Oct 2007 18:10:13 +0100 [thread overview]
Message-ID: <47276575.8080807@fr.ibm.com> (raw)
In-Reply-To: <1193762132.24087.265.camel@localhost>
Dave Hansen wrote:
> On Tue, 2007-10-30 at 14:06 +0100, Daniel Lezcano wrote:
>> Index: linux-2.6-netns/net/core/neighbour.c
>> ===================================================================
>> --- linux-2.6-netns.orig/net/core/neighbour.c
>> +++ linux-2.6-netns/net/core/neighbour.c
>> @@ -497,6 +497,7 @@ struct pneigh_entry * pneigh_lookup(stru
>> if (tbl->pconstructor && tbl->pconstructor(n)) {
>> if (dev)
>> dev_put(dev);
>> + release_net(n->net);
>> kfree(n);
>> n = NULL;
>> goto out;
>> _______________________________________________
>
> Looks like there are some tabs vs. spaces issues in there. You should
> probably just make your line match the ones around it.
Thanks Dave for pointing that. I stupidly did a copy/paste from emacs to
thunderbird. Grr ...
I will resend this patch with correct indentation. Benjamin spotted this
problem with the patches I sent to netdev@ too, they are already fixed.
Thansk again.
prev parent reply other threads:[~2007-10-30 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 13:06 [PATCH][NETNS] release net when pneigh_lookup fails Daniel Lezcano
[not found] ` <47272C3B.5080601-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2007-10-30 16:35 ` Dave Hansen
2007-10-30 17:10 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47276575.8080807@fr.ibm.com \
--to=dlezcano-nmtc/0zbporqt0dzr+alfa@public.gmane.org \
--cc=Containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=haveblue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.