From: Zach Brown <zach.brown@oracle.com>
To: Timur Tabi <timur@freescale.com>
Cc: apw@shadowen.org, linux-kernel@vger.kernel.org
Subject: Re: checkpatch bug: space between left parenthesis and asterisk
Date: Tue, 30 Oct 2007 12:54:16 -0700 [thread overview]
Message-ID: <47278BE8.6010901@oracle.com> (raw)
In-Reply-To: <47278591.90305@freescale.com>
Timur Tabi wrote:
> I'm running checkpatch.pl (dated 10/17), and it complains about this line:
>
> crc = __be32_to_cpu(* ((__be32 *) ((void *) firmware + calc_size)));
Well, that is a bit of a stinker. Maybe it could be reworked a little
to make it easier for humans and checkpatch to understand?
__be32 *crazy_pointer = (void *)firmware + calc_size;
crc = be32_to_cpu(*crazy_pointer);
(Does this need to worry about get_unaligned() at all?)
- z
next prev parent reply other threads:[~2007-10-30 19:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 19:27 checkpatch bug: space between left parenthesis and asterisk Timur Tabi
2007-10-30 19:54 ` Zach Brown [this message]
2007-10-30 20:02 ` Timur Tabi
2007-10-30 21:46 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47278BE8.6010901@oracle.com \
--to=zach.brown@oracle.com \
--cc=apw@shadowen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.