All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Steven A. Falco" <sfalco@harris.com>
To: linuxppc-dev@ozlabs.org
Subject: Re: PPC405GP Walnut irq patch
Date: Tue, 30 Oct 2007 17:41:27 -0400	[thread overview]
Message-ID: <4727A507.10309@harris.com> (raw)
In-Reply-To: <47279CF0.4050600@harris.com>

[-- Attachment #1: Type: text/plain, Size: 628 bytes --]

I realized that I should have done this from the root level.  So here is 
the corrected patch.

Signed-off-by: Steve Falco <sfalco at harris.com>


Steven A. Falco wrote:
> Hi - I have found a bug in the ARCH=powerpc Walnut BSP.  The order of 
> the ethernet interrupts in the walnut.dts file doesn't match the 
> documentation.  I discovered this when porting the BSP to a custom 
> board - the ethernet would not work.  The attached patch corrects that.
>
> This is the first patch I am submitting, so please advise me if there 
> is anything I should do differently.
>
> Signed-off-by: Steve Falco <sfalco at harris.com>
>
>

[-- Attachment #2: irq.patch --]
[-- Type: text/x-patch, Size: 660 bytes --]

diff --git a/arch/powerpc/boot/dts/walnut.dts b/arch/powerpc/boot/dts/walnut.dts
index 27bef06..dd65115 100644
--- a/arch/powerpc/boot/dts/walnut.dts
+++ b/arch/powerpc/boot/dts/walnut.dts
@@ -67,7 +67,7 @@
 			num-tx-chans = <2>;
 			num-rx-chans = <1>;
 			interrupt-parent = <&UIC0>;
-			interrupts = <a 4 b 4 c 4 d 4 e 4>;
+			interrupts = <b 4 c 4 a 4 d 4 e 4>;
 		};
 
 		POB0: opb {
@@ -117,7 +117,7 @@
 				device_type = "network";
 				compatible = "ibm,emac-405gp", "ibm,emac";
 				interrupt-parent = <&UIC0>;
-				interrupts = <9 4 f 4>;
+				interrupts = <f 4 9 4>;
 				reg = <ef600800 70>;
 				mal-device = <&MAL>;
 				mal-tx-channel = <0 1>;

  reply	other threads:[~2007-10-30 21:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-30 21:06 PPC405GP Walnut irq patch Steven A. Falco
2007-10-30 21:41 ` Steven A. Falco [this message]
2007-10-31  1:40   ` Josh Boyer
2007-10-31 17:52     ` Steven A. Falco
2007-11-01 12:23       ` Josh Boyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4727A507.10309@harris.com \
    --to=sfalco@harris.com \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.