From: Jeff Mahoney <jeffm@suse.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mmap: restore -ENODEV on missing f_op->mmap
Date: Tue, 30 Oct 2007 21:07:05 -0400 [thread overview]
Message-ID: <4727D539.3080103@suse.com> (raw)
In-Reply-To: <20071030161352.80656280.rdunlap@xenotime.net>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Randy Dunlap wrote:
> On Tue, 30 Oct 2007 15:45:56 -0700 (PDT) Linus Torvalds wrote:
>
>>
>> On Tue, 30 Oct 2007, Jeff Mahoney wrote:
>>> Personally, I think this is probably a case of LTP codifying existing
>>> behavior rather than testing the for the specification. If that's the case
>>> and nobody really cares about the change in behavior, I'm fine letting this
>>> drop.
>> Hmm.. I think it's kind of stupid adding that special case early on, just
>> to get one particular error case return when there are multiple possible
>> ones.
>>
>> I don't care deeply, but this does smell like a test issue rather than a
>> code issue.
>>
>> Looking at that path, there are *other* things that might be worth
>> cleaning up, but this wasn't one of them..
>
>
> Jeff, will you (at least) notify the LTP project of this issue and
> need for a patch?
Sure. I'll send that out tonight or tomorrow morning.
- -Jeff
- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.4-svn0 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org
iD8DBQFHJ9U5LPWxlyuTD7IRArcqAJ4hGnSf0Z67sLJJ6OU4t72VFodPnQCbBwHw
Usml2lnHxuwyXpXvjwlTbaI=
=ss6E
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2007-10-31 1:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 22:20 [PATCH] mmap: restore -ENODEV on missing f_op->mmap Jeff Mahoney
2007-10-30 22:45 ` Linus Torvalds
2007-10-30 23:13 ` Randy Dunlap
2007-10-31 1:07 ` Jeff Mahoney [this message]
2007-10-31 1:07 ` Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4727D539.3080103@suse.com \
--to=jeffm@suse.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.