From: Pavel Emelyanov <xemul@openvz.org>
To: David Miller <davem@davemloft.net>
Cc: Linux Netdev List <netdev@vger.kernel.org>, devel@openvz.org
Subject: [PATCH 0/8] Cleanup/fix the sk_alloc() call
Date: Wed, 31 Oct 2007 16:40:01 +0300 [thread overview]
Message-ID: <472885B1.7090103@openvz.org> (raw)
The sk_alloc() function suffers from two problems:
1 (major). The error path is not clean in it - if the security
call fails, the net namespace is not put, if the try_module_get
fails additionally the security context is not released;
2 (minor). The zero_it argument is misleading, as it doesn't just
zeroes it, but performs some extra setup. Besides this argument
is used only in one place - in the sk_clone().
So this set fixes these problems and performs some additional
cleanup.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
next reply other threads:[~2007-10-31 12:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 13:40 Pavel Emelyanov [this message]
2007-10-31 13:15 ` [PATCH 0/8] Cleanup/fix the sk_alloc() call Arnaldo Carvalho de Melo
2007-10-31 14:32 ` Pavel Emelyanov
2007-10-31 14:14 ` Arnaldo Carvalho de Melo
2007-10-31 13:42 ` [PATCH 1/8] Move the sock_copy() from the header Pavel Emelyanov
2007-11-01 7:30 ` David Miller
2007-10-31 13:44 ` [PATCH 2/8] Move the get_net() from sock_copy() Pavel Emelyanov
2007-11-01 7:32 ` David Miller
2007-10-31 13:47 ` [PATCH 3/8] Cleanup the allocation/freeing of the sock object Pavel Emelyanov
2007-11-01 7:34 ` David Miller
2007-10-31 13:48 ` [PATCH 4/8] Auto-zero the allocated " Pavel Emelyanov
2007-11-01 7:35 ` David Miller
2007-10-31 13:51 ` [PATCH 5/8] Move some core sock setup into sk_prot_alloc Pavel Emelyanov
2007-11-01 7:36 ` David Miller
2007-10-31 13:54 ` [PATCH 6/8] Make the sk_clone() lighter Pavel Emelyanov
2007-11-01 7:26 ` David Miller
2007-11-01 8:46 ` Pavel Emelyanov
2007-11-01 7:38 ` David Miller
2007-10-31 13:56 ` [PATCH 7/8] Remove bogus zero_it argument from sk_alloc Pavel Emelyanov
2007-11-01 7:38 ` David Miller
2007-10-31 13:59 ` [PATCH 8/8] Forget the zero_it argument of sk_alloc() Pavel Emelyanov
2007-11-01 7:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=472885B1.7090103@openvz.org \
--to=xemul@openvz.org \
--cc=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.