From: Jens Gehrlein <sew_s@tqs.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] 83xx: fix CFG_ENV_ADDR and CFG_ENV_SECT_SIZE definitions
Date: Wed, 31 Oct 2007 17:14:00 +0100 [thread overview]
Message-ID: <4728A9C8.50300@tqs.de> (raw)
In-Reply-To: <4728A415.3040800@freescale.com>
Timur Tabi wrote:
> Jens Gehrlein wrote:
>
>> IMHO this would work only if the sum of
>> CFG_MONITOR_BASE + CFG_MONITOR_LEN is sector aligned.
>> Did you set CFG_MONITOR_LEN appropriately?
>> (Just to avoid unexpected behaviour)
>
> I'm under the assumption that CFG_MONITOR_LEN is always supposed to be a
> multiple of the sector size. Should I add comments to the header files
> to state that explicitly?
>
It's just, because I saw implementations, where CFG_MONITOR_LEN was an
arbitrary value. It depends on how the developer interpretes this
define and how it is used in the cpu and board specific code.
Maybe a comment would help, but I leave the decision to you.
Best regards
Jens
next prev parent reply other threads:[~2007-10-31 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 15:23 [U-Boot-Users] 83xx: fix CFG_ENV_ADDR and CFG_ENV_SECT_SIZE definitions Timur Tabi
2007-10-31 15:47 ` Jens Gehrlein
2007-10-31 15:49 ` Timur Tabi
2007-10-31 16:14 ` Jens Gehrlein [this message]
2007-11-03 21:49 ` Wolfgang Denk
2007-11-04 15:26 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4728A9C8.50300@tqs.de \
--to=sew_s@tqs.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.