From: Jeff Garzik <jeff@garzik.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: linux-kernel@vger.kernel.org, kristen.c.accardi@intel.com,
linux-ide@vger.kernel.org
Subject: Re: Suspend to ram regression (2.6.24-rc1-git)
Date: Thu, 01 Nov 2007 07:20:16 -0400 [thread overview]
Message-ID: <4729B670.7090403@garzik.org> (raw)
In-Reply-To: <20071101092155.GB5037@kernel.dk>
Jens Axboe wrote:
> Reverting just the default AHCI flags makes it work again. IOW, with the
> below patch I can suspend properly with current -git.
>
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index ed9b407..77f7631 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -190,8 +190,7 @@ enum {
>
> AHCI_FLAG_COMMON = ATA_FLAG_SATA | ATA_FLAG_NO_LEGACY |
> ATA_FLAG_MMIO | ATA_FLAG_PIO_DMA |
> - ATA_FLAG_ACPI_SATA | ATA_FLAG_AN |
> - ATA_FLAG_IPM,
> + ATA_FLAG_ACPI_SATA | ATA_FLAG_AN,
> AHCI_LFLAG_COMMON = ATA_LFLAG_SKIP_D2H_BSY,
sounds like the easy thing to do, in light of this breakage, might be to
default it to off, add a module parameter turning it on by setting that
flag.
next prev parent reply other threads:[~2007-11-01 11:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 20:13 Suspend to ram regression (2.6.24-rc1-git) Jens Axboe
2007-11-01 8:41 ` Jens Axboe
2007-11-01 9:21 ` Jens Axboe
2007-11-01 9:25 ` Jens Axboe
2007-11-01 11:20 ` Jeff Garzik [this message]
2007-11-01 11:24 ` Jens Axboe
2007-11-01 11:55 ` Jeff Garzik
2007-11-01 12:01 ` Jens Axboe
2007-11-01 16:58 ` Kristen Carlson Accardi
2007-11-02 23:37 ` Kristen Carlson Accardi
2007-11-03 6:23 ` Theodore Tso
2007-11-03 17:02 ` Arjan van de Ven
2007-11-05 12:47 ` Jens Axboe
2007-11-05 12:53 ` Jeff Garzik
2007-11-05 17:21 ` Kristen Carlson Accardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4729B670.7090403@garzik.org \
--to=jeff@garzik.org \
--cc=jens.axboe@oracle.com \
--cc=kristen.c.accardi@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.