Re: [PATCH] RFC: move ath5k to use pci_request_selected_regions()

[Jeff Garzik <jeff@garzik.org>]

Luis R. Rodriguez wrote:
> Documentation/pci.txt states:
> 
> "If your PCI device driver doesn't need I/O port resources assigned to
> I/O Port BARs, you should use pci_enable_device_bars() instead of
> pci_enable_device() in order not to enable I/O port regions for the
> corresponding devices. In addition, you should use
> pci_request_selected_regions() and pci_release_selected_regions()
> instead of pci_request_regions()/pci_release_regions() in order not to
> request/release I/O port regions for the corresponding devices."
> 
> So shall we? This also re-arranges the pci_release_selected_regions()
> as per the documenation.
> 
> Changes to base.c
> Changes-licensed-under: 3-clause-BSD
> 
> Signed-off-by: Luis R. Rodriguez <mcgrof@gmail.com>

IMO the documentation is a bit bogus:

pci_request_regions() ensures that nobody else will touch -any- of your 
resources.

I see no logical reason to enable sharing of I/O regions with another 
driver, which would be the net effect of avoiding their request/release 
by using pci_request_selected_regions()

pci_enable_device() and pci_request_regions() are just fine; the strange 
and lesser-used APIs should be avoided unless you _need_ to use them.

	Jeff