From: Jeff Garzik <jeff@garzik.org>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, davej@redhat.com,
auke-jan.h.kok@intel.com, ajax@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] e1000, e1000e valid-addr fixes
Date: Thu, 01 Nov 2007 15:31:21 -0400 [thread overview]
Message-ID: <472A2989.2060603@garzik.org> (raw)
In-Reply-To: <20071101111157.7f3e4f58@freepuppy.rosehill>
Stephen Hemminger wrote:
> How about:
>
> static int eth_validate_addr(const struct net_device *dev)
> {
> return is_valid_ether_addr(dev->dev_addr) ? 0 : -EINVAL;
> }
hmmm -- its a slow path, so I don't see the value of marking the
argument 'const' -- right now this implementation merely reads the
dev->dev_addr[], but that need not always be the case.
And I don't see the value of squashing everything onto one line, IMO the
current version is more readable.
Jeff
next prev parent reply other threads:[~2007-11-01 19:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 14:58 [PATCH] Add eeprom_bad_csum_allow module option to e1000 Adam Jackson
2007-10-23 16:18 ` Kok, Auke
2007-10-23 16:21 ` Adam Jackson
2007-10-23 17:09 ` Kok, Auke
2007-10-23 20:40 ` Jeff Garzik
2007-10-23 21:01 ` Kok, Auke
2007-10-23 21:51 ` David Miller
2007-10-23 21:20 ` Dave Jones
2007-10-23 21:38 ` Alan Cox
2007-10-23 21:53 ` David Miller
2007-10-23 23:19 ` Kok, Auke
2007-10-24 0:55 ` [PATCH] e1000, e1000e valid-addr fixes Jeff Garzik
2007-10-24 1:03 ` Jeff Garzik
2007-10-24 1:07 ` David Miller
2007-10-24 2:20 ` Jeff Garzik
2007-10-24 2:23 ` David Miller
2007-11-01 18:04 ` Kok, Auke
2007-11-01 18:47 ` Jeff Garzik
2007-11-01 18:11 ` Stephen Hemminger
2007-11-01 19:31 ` Jeff Garzik [this message]
2007-10-24 1:15 ` Adrian Bunk
2007-10-23 23:03 ` [PATCH] Add eeprom_bad_csum_allow module option to e1000 Kok, Auke
2007-10-23 23:03 ` Kok, Auke
2007-10-23 23:53 ` Stephen Hemminger
2007-10-24 5:38 ` Dave Jones
2007-10-23 21:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=472A2989.2060603@garzik.org \
--to=jeff@garzik.org \
--cc=ajax@redhat.com \
--cc=auke-jan.h.kok@intel.com \
--cc=davej@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.