All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kok, Auke" <auke-jan.h.kok@intel.com>
To: Joe Perches <joe@perches.com>
Cc: Auke Kok <auke-jan.h.kok@intel.com>,
	netdev <netdev@vger.kernel.org>,
	e1000-devel@lists.sourceforge.net,
	Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH] - e1000_ethtool.c - convert macros to functions
Date: Thu, 01 Nov 2007 14:29:17 -0700	[thread overview]
Message-ID: <472A452D.7080208@intel.com> (raw)
In-Reply-To: <1193951813.17956.3.camel@localhost>

Joe Perches wrote:
> Minimal macro to function conversion in e1000_ethtool.c
> 
> Adds functions reg_pattern_test and reg_set_and_check
> Changes REG_PATTERN_TEST and REG_SET_AND_CHECK macros
> to call these functions.
> 
> Saves ~2.5KB
> 
> Compiled x86, untested (no hardware)
> 
> old:
> 
> $ size drivers/net/e1000/e1000_ethtool.o
>    text    data     bss     dec     hex filename
>   16778       0       0   16778    418a drivers/net/e1000/e1000_ethtool.o
> 
> new:
> 
> $ size drivers/net/e1000/e1000_ethtool.o
>    text    data     bss     dec     hex filename
>   14128       0       0   14128    3730 drivers/net/e1000/e1000_ethtool.o
> 
> Signed-off-by: Joe Perches <joe@perches.com>



ok, looks good and it'll get tested with the e1000e version.

Thanks

Auke

  reply	other threads:[~2007-11-01 21:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-01 21:16 [PATCH] - e1000_ethtool.c - convert macros to functions Joe Perches
2007-11-01 21:29 ` Kok, Auke [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-10-31 21:18 Joe Perches
2007-10-31 21:30 ` Kok, Auke
2007-10-31 23:15   ` Joe Perches
2007-11-01  0:39     ` Kok, Auke
2007-11-01  0:34   ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=472A452D.7080208@intel.com \
    --to=auke-jan.h.kok@intel.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=jgarzik@pobox.com \
    --cc=joe@perches.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.