Neil Brown wrote:
> Thanks Chuck.
> This series all:
>    Acked-By: NeilBrown <neilb@suse.de>
> 
> Just one question:
> 
>> diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
>> index fdc5e6d..31bd346 100644
>> --- a/net/sunrpc/xdr.c
>> +++ b/net/sunrpc/xdr.c
>> @@ -93,11 +93,13 @@ xdr_encode_string(__be32 *p, const char *string)
>>  }
>>  
>>  __be32 *
>> -xdr_decode_string_inplace(__be32 *p, char **sp, int *lenp, int maxlen)
>> +xdr_decode_string_inplace(__be32 *p, char **sp,
>> +			  unsigned int *lenp, unsigned int maxlen)
>>  {
>> -	unsigned int	len;
>> +	u32 len;
> 
> What is the reason for making this a u32?  You seem to be happy with
> "unsigned int" everywhere else.
> 
> It's not important, but I'm curious.

It boils down to documenting exactly what comes off the wire, 
independent of what the local "unsigned int" is.