From: Christian Franke <Christian.Franke@t-online.de>
To: grub-devel@gnu.org
Subject: [PATCH] Fix grub-emu curses KEY_* mapping
Date: Fri, 02 Nov 2007 22:55:11 +0100 [thread overview]
Message-ID: <472B9CBF.9030702@t-online.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 589 bytes --]
Curses function keys do not work in grub-emu, this patch fixes this in
grub_ncurses_getkey().
Another approach would be to remove the scancode translation in
grub_console_getkey(), and check for GRUB_CONSOLE_KEY_* in
grub_cmdline_get() instead. The GRUB_CONSOLE_KEY_* definitions are
already platform specific.
Christian
2007-11-02 Christian Franke <franke@computer.org>
* util/console.c (grub_ncurses_getkey): Change curses KEY_* mapping,
now return control chars instead of GRUB_CONSOLE_KEY_* constants.
This fixes the problem that function keys did not work in grub-emu.
[-- Attachment #2: grub2-console-key.patch --]
[-- Type: text/x-patch, Size: 1836 bytes --]
--- grub2.orig/util/console.c 2007-07-22 01:32:31.000000000 +0200
+++ grub2/util/console.c 2007-10-13 16:13:46.000000000 +0200
@@ -161,53 +161,59 @@ grub_ncurses_getkey (void)
c = getch ();
}
+ /* XXX: return GRUB_CONSOLE_KEY_* does not work here,
+ grub_cmdline_get() does not check for these constants.
+ At least on i386-pc, GRUB_CONSOLE_KEY_* are in fact keyboard
+ scancodes which are converted into control chars by
+ grub_console_getkey(). */
+
switch (c)
{
case KEY_LEFT:
- c = GRUB_CONSOLE_KEY_LEFT;
+ c = 2; /*GRUB_CONSOLE_KEY_LEFT*/
break;
case KEY_RIGHT:
- c = GRUB_CONSOLE_KEY_RIGHT;
+ c = 6; /*GRUB_CONSOLE_KEY_RIGHT*/
break;
case KEY_UP:
- c = GRUB_CONSOLE_KEY_UP;
+ c = 16; /*GRUB_CONSOLE_KEY_UP*/
break;
case KEY_DOWN:
- c = GRUB_CONSOLE_KEY_DOWN;
+ c = 14; /*GRUB_CONSOLE_KEY_DOWN*/
break;
case KEY_IC:
- c = GRUB_CONSOLE_KEY_IC;
+ c = 24; /*GRUB_CONSOLE_KEY_IC*/
break;
case KEY_DC:
- c = GRUB_CONSOLE_KEY_DC;
+ c = 4; /*GRUB_CONSOLE_KEY_DC*/
break;
case KEY_BACKSPACE:
/* XXX: For some reason ncurses on xterm does not return
KEY_BACKSPACE. */
case 127:
- c = GRUB_CONSOLE_KEY_BACKSPACE;
+ c = 8; /*GRUB_CONSOLE_KEY_BACKSPACE*/;
break;
case KEY_HOME:
- c = GRUB_CONSOLE_KEY_HOME;
+ c = 1; /*GRUB_CONSOLE_KEY_HOME*/
break;
case KEY_END:
- c = GRUB_CONSOLE_KEY_END;
+ c = 5; /*GRUB_CONSOLE_KEY_END*/
break;
case KEY_NPAGE:
- c = GRUB_CONSOLE_KEY_NPAGE;
+ c = 3; /*GRUB_CONSOLE_KEY_NPAGE*/
break;
case KEY_PPAGE:
- c = GRUB_CONSOLE_KEY_PPAGE;
+ c = 7; /*GRUB_CONSOLE_KEY_PPAGE*/
break;
}
next reply other threads:[~2007-11-02 21:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-02 21:55 Christian Franke [this message]
2007-11-09 15:17 ` [PATCH] Fix grub-emu curses KEY_* mapping Marco Gerards
2007-11-10 13:09 ` Christian Franke
2007-11-10 15:25 ` Marco Gerards
2007-11-18 7:20 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=472B9CBF.9030702@t-online.de \
--to=christian.franke@t-online.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.