From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/6] libata: fix timing computation in ata_eh_reset()
Date: Sat, 03 Nov 2007 08:48:51 -0400 [thread overview]
Message-ID: <472C6E33.9000402@garzik.org> (raw)
In-Reply-To: <11937934272494-git-send-email-htejun@gmail.com>
Tejun Heo wrote:
> As jiffies changes asynchronously, it needs to be cached if unchanging
> timestamp is needed. The code in ata_eh_reset() intended to do that
> with @now but never actually did it. Fix it.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/libata-eh.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index 496edaf..f1c0117 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -2184,7 +2184,7 @@ int ata_eh_reset(struct ata_link *link, int classify,
> unsigned long now = jiffies;
>
> if (time_before(now, deadline)) {
> - unsigned long delta = deadline - jiffies;
> + unsigned long delta = deadline - now;
applied 1-6 to #upstream-fixes
next prev parent reply other threads:[~2007-11-03 12:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 1:17 [PATCHSET] libata: update EH / configuration behavior Tejun Heo
2007-10-31 1:17 ` [PATCH 1/6] libata: fix timing computation in ata_eh_reset() Tejun Heo
2007-11-03 12:48 ` Jeff Garzik [this message]
2007-10-31 1:17 ` [PATCH 2/6] libata: cosmetic clean up / reorganization of ata_eh_reset() Tejun Heo
2007-10-31 1:17 ` [PATCH 3/6] libata: more robust reset failure handling Tejun Heo
2007-10-31 1:17 ` [PATCH 4/6] libata: consider errors not associated with commands for speed down Tejun Heo
2007-10-31 1:17 ` [PATCH 5/6] libata: request PHY speed configuration on SControl access failure Tejun Heo
2007-10-31 1:17 ` [PATCH 6/6] libata: don't configure downstream links faster than the upstream link Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=472C6E33.9000402@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.