From: Andrew Morgan <morgan@kernel.org>
To: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: Stephen Smalley <sds@epoch.ncsc.mil>,
lkml <linux-kernel@vger.kernel.org>,
linux-security-module@vger.kernel.org,
Andrew Morton <akpm@osdl.org>, Chris Wright <chrisw@sous-sol.org>,
"Theodore Ts'o" <tytso@mit.edu>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Natalie Protasevich <protasnb@gmail.com>
Subject: Re: [PATCH] file capabilities: allow sigcont within session (v2)
Date: Sat, 03 Nov 2007 14:31:08 -0700 [thread overview]
Message-ID: <472CE89C.2020801@kernel.org> (raw)
In-Reply-To: <20071101134701.GA21131@sergelap.austin.ibm.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Serge E. Hallyn wrote:
> Quoting Stephen Smalley (sds@epoch.ncsc.mil):
>> On Wed, 2007-10-31 at 18:49 -0500, Serge E. Hallyn wrote:
[..]
>>> Also don't do file-capabilities signaling checks when uids for
>>> the processes don't match, since the standard check_kill_permission
>>> will have done those checks.
>> Description doesn't match the code.
>
> Egads. I knew I should've just kept that part out of it for the first
> patch...
>
> New patch on top of previous one is appended.
Dang! I stared at the code a long time to see what you were doing...
And concluded that you had coded what you intended; allow processes that
share UIDs to kill one another - independent of capabilities. The fact
that this is the reverse of the words you used to introduce your patch,
I didn't notice.
I totally missed the fact that this was (unwanted) new functionality!!
Mea culpa for the bad review.
I certainly Sign off the revised patch.
Cheers
Andrew
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHLOicmwytjiwfWMwRAq5HAJ49eajMT4myf1oKfrab2oCw/o9HnwCgkYt2
RyIsmHVWmClsrxCz5s1HRJY=
=hGLO
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2007-11-03 21:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 23:49 [PATCH] file capabilities: allow sigcont within session (v2) Serge E. Hallyn
2007-11-01 1:27 ` Andrew Morgan
2007-11-01 4:47 ` Andrew Morgan
2007-11-01 12:07 ` Stephen Smalley
2007-11-01 13:47 ` Serge E. Hallyn
2007-11-01 20:12 ` Theodore Tso
2007-11-02 1:54 ` Theodore Tso
2007-11-03 21:31 ` Andrew Morgan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=472CE89C.2020801@kernel.org \
--to=morgan@kernel.org \
--cc=akpm@osdl.org \
--cc=chrisw@sous-sol.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=protasnb@gmail.com \
--cc=rjw@sisk.pl \
--cc=sds@epoch.ncsc.mil \
--cc=serue@us.ibm.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.