From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <junkio@cox.net>, Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH 3/5] pretty describe: move library functions to the new file describe.c
Date: Sun, 04 Nov 2007 15:56:00 +0100 [thread overview]
Message-ID: <472DDD80.2010203@lsrfire.ath.cx> (raw)
In-Reply-To: <Pine.LNX.4.64.0711041435540.4362@racer.site>
Johannes Schindelin schrieb:
> Hi,
>
> On Sun, 4 Nov 2007, Ren? Scharfe wrote:
>
>> Makefile | 2 +-
>> builtin-describe.c | 202 ---------------------------------------------------
>> cache.h | 5 ++
>> describe.c | 204 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>> 4 files changed, 210 insertions(+), 203 deletions(-)
>> create mode 100644 describe.c
>
> Would not "format-patch -C -C" have given a nicer output?
Yes, it would have been shorter, but it looks a bit strange, because it's
deleting stuff from the new file describe.c (i.e. all the things left in
builtin-describe.c):
Makefile | 2 +-
builtin-describe.c | 202 --------------------------------------
cache.h | 5 +
builtin-describe.c => describe.c | 85 ----------------
4 files changed, 6 insertions(+), 288 deletions(-)
copy builtin-describe.c => describe.c (66%)
That's 367 lines of patch + stat vs. 470 lines for the one I sent. Will
use next time.
Thanks,
René
prev parent reply other threads:[~2007-11-04 14:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-04 11:48 [PATCH 3/5] pretty describe: move library functions to the new file describe.c René Scharfe
2007-11-04 14:36 ` Johannes Schindelin
2007-11-04 14:56 ` René Scharfe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=472DDD80.2010203@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.