All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
Cc: nfs@lists.sourceforge.net
Subject: Re: [PATCH nfs-utils 3/3] Fix bug in auto-exporting subordinate mounts.
Date: Mon, 05 Nov 2007 04:54:52 -0500	[thread overview]
Message-ID: <472EE86C.9080908@RedHat.com> (raw)
In-Reply-To: <1193894817-20622-4-git-send-email-neilb@suse.de>



Neil Brown wrote:
> When mountd gets a request to export a mountpoint which is not
> explicitly exported, but is below an export point that is flagged as
> "crossmnt", it passes the wrong path name to the kernel for the
>   "filehandle -> directory"
> mapping.
> This can badly confuse the NFS client, and is certainly wrong.
> 
> So use the correct path names.
> 
> Signed-off-by: Neil Brown <neilb@suse.de>
> ---
>  utils/mountd/cache.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
> index ce1a5a9..fd317cd 100644
> --- a/utils/mountd/cache.c
> +++ b/utils/mountd/cache.c
> @@ -508,7 +508,7 @@ void nfsd_fh(FILE *f)
>  	 */
>  	qword_printint(f, 0x7fffffff);
>  	if (found)
> -		qword_print(f, found->e_path);
> +		qword_print(f, found_path);
>  	qword_eol(f);
>   out:
>  	free(found_path);
Committed.

steved.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

  reply	other threads:[~2007-11-05  9:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-01  5:26 [PATCH nfs-utils] probe_port should not try other versions in a version was explicitly given Neil Brown
2007-11-01  5:26 ` [PATCH nfs-utils 1/3] " Neil Brown
2007-11-01  5:26   ` [PATCH nfs-utils 2/3] Correctly probe mount v2 Neil Brown
2007-11-01  5:26     ` [PATCH nfs-utils 3/3] Fix bug in auto-exporting subordinate mounts Neil Brown
2007-11-05  9:54       ` Steve Dickson [this message]
2007-11-05 10:58     ` [PATCH nfs-utils 2/3] Correctly probe mount v2 Steve Dickson
2007-11-05 18:01       ` Peter Staubach
2007-11-01 16:29   ` [PATCH nfs-utils 1/3] probe_port should not try other versions in a version was explicitly given Chuck Lever
2007-11-02  2:02     ` Neil Brown
2007-11-02 17:01       ` Chuck Lever
2007-11-05  9:55   ` Steve Dickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=472EE86C.9080908@RedHat.com \
    --to=steved@redhat.com \
    --cc=nfs@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.