From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Winchell Subject: Re: [PATCH] Add a timer mode that disables pending missed ticks Date: Mon, 05 Nov 2007 09:36:43 -0500 Message-ID: <472F2A7B.4020308@virtualiron.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: "Dong, Eddie" , Dave Winchell , xen-devel@lists.xensource.com, "Shan, Haitao" , "Jiang, Yunhong" List-Id: xen-devel@lists.xenproject.org Keir Fraser wrote: >On 3/11/07 21:17, "Dave Winchell" wrote: > > > >>Thanks for applying the fixes in the last submit. >>In moving the test for no_missed_tick_accounting into >>pt_process_missed_ticks() >>you forgot to add the scheduling part. >> >> > >Actually it was deliberate, but clearly it was one code simplification too >far: thanks for spotting it! I'll go the async route, but we do need to set >pending_intr_nr to 1. We can't leave that out -- the point of the async >route is to send a tick to the vcpu immediately, since it hasn't had one for >more than a tick period. If we wait for the timeout to do that then we have >to wait a whole extra period after the vcpu is re-scheduled. > >Attached is my proposed patch. I think it's quite neat. :-) > > It looks good to me. thanks, Dave > -- Keir > > >