From: Johannes Sixt <j.sixt@viscovery.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Daniel Barkalow <barkalow@iabervon.org>, git@vger.kernel.org
Subject: Re: [RFC PATCH] Reduce the number of connects when fetching
Date: Tue, 06 Nov 2007 09:13:12 +0100 [thread overview]
Message-ID: <47302218.3060409@viscovery.net> (raw)
In-Reply-To: <7v1wb4kuoc.fsf@gitster.siamese.dyndns.org>
Junio C Hamano schrieb:
> Daniel Barkalow <barkalow@iabervon.org> writes:
>> ... In particular, I don't know if there's a way to have the
>> connection end up in a state where objects for more refs can be requested
>> after some refs have been requested and the resulting objects read.
>
> The upload-pack protocol goes "S: here are what I have, C: I
> want these, C: I have these, S: ok, continue, C: I have these,
> S: ok, continue, C: I have these, S: ok, I've heard enough, C:
> done, S: packfile is here", so after packfile generation starts
> there is nothing further the downloader can say.
>
> Otherwise you would be able to do the tag following using the
> same connection, but that is unfortunately not a case.
How about:
S: here are what I have
C: I want these
C: want tags <-- new
C: I have these
S: ok, continue
C: I have these
S: ok, continue
C: I have these
S: ok, these are the tags <-- new
S: I've heard enough
C: done
S: packfile is here
The tags that the server provides are those (and only those[*]) that
reference objects in the packfile that it's going to send.
[*] This way the client doesn't have to figure out which tags it wants; as a
side-effect it won't accidentally fetch tags for objects that it happens to
have in the repository, but aren't reachable from any ref (like what used to
happen).
-- Hannes
next prev parent reply other threads:[~2007-11-06 8:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-04 21:28 [RFC PATCH] Reduce the number of connects when fetching Daniel Barkalow
2007-11-06 1:51 ` Junio C Hamano
2007-11-06 3:04 ` Daniel Barkalow
2007-11-06 5:03 ` Junio C Hamano
2007-11-06 8:13 ` Johannes Sixt [this message]
2007-11-06 8:34 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47302218.3060409@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.