From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Akio Takebe <takebe_akio-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [Patch] improvement of "make rpm"
Date: Tue, 06 Nov 2007 11:01:19 +0200 [thread overview]
Message-ID: <47302D5F.9070801@qumranet.com> (raw)
In-Reply-To: <6C82012B93D81takebe_akio-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
Akio Takebe wrote:
>>>
>>> -%prep
>>> +%if %([ x"%{Distribution}" = x"fedora" -a x"%{os_release}" = x"5" ] &&
>>> echo 1 |
>>> | echo 0)
>>> +%define fedora5 1
>>> +%endif
>>>
>>>
>> Why not use regular rpm conditionals instead of calling the shell?
>>
>>
> The regular rpm conditionals are poor facilities.
> Shell has better parsing facilities.
> The original checking fedora5 and centos4 doesn't work on RHEL5.
> So I changed the checking with shell.
>
>
Okay.
>> Can you add an explicit test for RHEL 5?
>>
> OK, I'll add it.
>
Okay, thanks.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
prev parent reply other threads:[~2007-11-06 9:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 14:32 [Patch] improvement of "make rpm" Akio Takebe
[not found] ` <EAC81BCAE411F0takebe_akio-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2007-11-01 12:39 ` Avi Kivity
[not found] ` <4729C8FF.8020607-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-06 1:16 ` Akio Takebe
[not found] ` <6C82012B93D81takebe_akio-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2007-11-06 9:01 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47302D5F.9070801@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=takebe_akio-+CUm20s59erQFUHtdCDX3A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.