All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 10/18] ide: make 'extra' field in struct ide_port_info u8
Date: Tue, 06 Nov 2007 14:40:34 +0300	[thread overview]
Message-ID: <473052B2.3000800@ru.mvista.com> (raw)
In-Reply-To: <200711050025.03967.bzolnier@gmail.com>

Bartlomiej Zolnierkiewicz wrote:
> The maximum value used currently for 'extra' field in struct ide_port_info
> is 240.

    It just can't exceed 240 (256 - 16).

> Make 'extra' u8 so it packs nicely together with enablebits[] and 'chipset'
> fields (ide_pci_enablebit_t is 3 bytes and hwif_chipset_t is 1 byte).

> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

MBR, Sergei

      reply	other threads:[~2007-11-06 11:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-04 23:25 [PATCH 10/18] ide: make 'extra' field in struct ide_port_info u8 Bartlomiej Zolnierkiewicz
2007-11-06 11:40 ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=473052B2.3000800@ru.mvista.com \
    --to=sshtylyov@ru.mvista.com \
    --cc=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.