From: Jeff Garzik <jeff@garzik.org>
To: Sreenivasa Honnur <Sreenivasa.Honnur@neterion.com>
Cc: netdev@vger.kernel.org, support@neterion.com
Subject: Re: [PATCH 2.6.24 1/1]S2io: Fixed memory leak by freeing MSI-X local entry memories when vector allocation fails
Date: Tue, 06 Nov 2007 12:46:26 -0500 [thread overview]
Message-ID: <4730A872.6030801@garzik.org> (raw)
In-Reply-To: <Pine.GSO.4.10.10710310408190.9897-100000@guinness>
Sreenivasa Honnur wrote:
> - Fixed memory leak by freeing MSI-X local entry memories when vector allocation
> fails in s2io_add_isr.
> - Added two utility functions remove_msix_isr and remove_inta_isr to eliminate
> code duplication.
> - Implemented following review comments from Jeff
> - Removed redundant stats->mem_freed and synchronize_irq call
> - do_rem_msix_isr is renamed as remove_msix_isr
> - do_rem_inta_isr is renamed as remove_inta_isr
>
> Signed-off-by: Sreenivasa Honnur <sreenivasa.honnur@neterion.com>
> Signed-off-by: Ramkrishna Vepa <ram.vepa@neterion.com>
this patch should go into 2.6.24-rc, but it doesn't apply to upstream.
This may be because it requires "S2io: Support for
add/delete/store/restore ethernet addresses", I am guessing?
We want to reverse the order of those two patches, because "S2io:
Support for add/delete/store/restore ethernet addresses" is more
appropriate for non-bug-fix 2.6.24 rather than current bugfix-only
2.6.24-rc.
Jeff
next prev parent reply other threads:[~2007-11-06 17:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 8:10 [PATCH 2.6.24 1/1]S2io: Fixed memory leak by freeing MSI-X local entry memories when vector allocation fails Sreenivasa Honnur
2007-11-06 17:46 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-11-14 9:29 Sreenivasa Honnur
2007-11-14 9:41 ` David Miller
2007-11-24 3:03 ` Jeff Garzik
2007-11-24 5:48 ` Ramkrishna Vepa
2007-11-24 6:56 ` Jeff Garzik
2007-10-28 8:05 Sivakumar Subramani
2007-10-29 9:55 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4730A872.6030801@garzik.org \
--to=jeff@garzik.org \
--cc=Sreenivasa.Honnur@neterion.com \
--cc=netdev@vger.kernel.org \
--cc=support@neterion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.