From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1IpW5R-0007HB-2n
	for mharc-grub-devel@gnu.org; Tue, 06 Nov 2007 16:35:53 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IpW5P-0007GX-2Z
	for grub-devel@gnu.org; Tue, 06 Nov 2007 16:35:51 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IpW5N-0007Fr-Gw
	for grub-devel@gnu.org; Tue, 06 Nov 2007 16:35:50 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IpW5N-0007Fi-Ab
	for grub-devel@gnu.org; Tue, 06 Nov 2007 16:35:49 -0500
Received: from pne-smtpout4-sn2.hy.skanova.net ([81.228.8.154])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <chaac@nic.fi>) id 1IpW5N-0002xI-1B
	for grub-devel@gnu.org; Tue, 06 Nov 2007 16:35:49 -0500
Received: from [127.0.0.1] (88.193.32.97) by pne-smtpout4-sn2.hy.skanova.net
	(7.3.129) id 471A7B0C000ED44C for grub-devel@gnu.org;
	Tue, 6 Nov 2007 22:35:30 +0100
Message-ID: <4730DDB8.4090902@nic.fi>
Date: Tue, 06 Nov 2007 23:33:44 +0200
From: =?ISO-8859-1?Q?Vesa_J=E4=E4skel=E4inen?= <chaac@nic.fi>
User-Agent: Thunderbird 2.0.0.6 (Windows/20070728)
MIME-Version: 1.0
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <E1IpVtw-0001l3-2T@cvs.savannah.gnu.org>
In-Reply-To: <E1IpVtw-0001l3-2T@cvs.savannah.gnu.org>
X-Enigmail-Version: 0.95.5
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta)
Subject: Re: grub2 ChangeLog term/i386/pc/serial.c
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Nov 2007 21:35:51 -0000

Robert Millan wrote:
> CVSROOT:	/sources/grub
> Module name:	grub2
> Changes by:	Robert Millan <robertmh>	07/11/06 21:23:59
> 
> Modified files:
> 	.              : ChangeLog 
> 	term/i386/pc   : serial.c 
> 
> Log message:
> 	2007-11-06  Robert Millan  <rmh@aybabtu.com>
> 	
> 		* term/i386/pc/serial.c (serial_hw_put): Switch order of arguments
> 		in grub_outb() calls.
> 		(serial_hw_init): Likewise.
> 
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/grub2/ChangeLog?cvsroot=grub&r1=1.437&r2=1.438
> http://cvs.savannah.gnu.org/viewcvs/grub2/term/i386/pc/serial.c?cvsroot=grub&r1=1.4&r2=1.5

Why on earth those parameters are reversed anyway :) ?

On all systems that I can remember arguments for lots of things go like
this:

func(destination, source)

examples are:
memcpy, strcpy

On most of the other systems outp is also outp(port, value)
("destination, source"). Eg. following the same convention.