Re: [PATCH] fix the number of bytes cleaned by clean_nat() in net/ipv4/netfilter/nf_nat_core.c

[Patrick McHardy <kaber@trash.net>]

Roel Kluin wrote:
> Zero out 'sizeof(*nat)' rather than 'sizeof(nat)' bytes of the struct 
> nf_conn_nat pointer 'nat'
> 
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/net/ipv4/netfilter/nf_nat_core.c b/net/ipv4/netfilter/nf_nat_core.c
> index 56e93f6..70e7997 100644
> --- a/net/ipv4/netfilter/nf_nat_core.c
> +++ b/net/ipv4/netfilter/nf_nat_core.c
> @@ -681,7 +681,7 @@ static int clean_nat(struct nf_conn *i, void *data)
>  
>  	if (!nat)
>  		return 0;
> -	memset(nat, 0, sizeof(nat));
> +	memset(nat, 0, sizeof(*nat));
>  	i->status &= ~(IPS_NAT_MASK | IPS_NAT_DONE_MASK | IPS_SEQ_ADJUST);
>  	return 0;
>  }


I already have the same patch queued from Li Zefan. Good catch anyway :)