All of lore.kernel.org
 help / color / mirror / Atom feed
From: Moni Shoua <monisonlists@gmail.com>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: netdev@vger.kernel.org, jgarzik@pobox.com
Subject: Re: [PATCH 1/2] bonding: fix rtnl locking merge error
Date: Wed, 07 Nov 2007 16:45:23 +0200	[thread overview]
Message-ID: <4731CF83.20107@gmail.com> (raw)
In-Reply-To: <11943848132752-git-send-email-fubar@us.ibm.com>

Jay Vosburgh wrote:
> 	Looks like I incorrectly merged one of the rtnl lock changes,
> so that one function, bonding_show_active_slave, held rtnl but didn't
> release it, and another, bonding_store_active_slave, never held rtnl but
> did release it.
> 
> 	Fixed so the first function doesn't mess with rtnl, and the
> second correctly acquires and releases rtnl.
> 
> 	Bug reported by Moni Shoua <monis@voltaire.com>

I ran some shallow tests and it seems that the patch fixes  the problem.

thanks


  parent reply	other threads:[~2007-11-07 14:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-06 21:33 [PATCH 0/2] bonding: Two small fixes Jay Vosburgh
2007-11-06 21:33 ` [PATCH 1/2] bonding: fix rtnl locking merge error Jay Vosburgh
2007-11-06 21:33   ` [PATCH 2/2] bonding: don't validate address at device open Jay Vosburgh
2007-11-07 14:45   ` Moni Shoua [this message]
2007-11-08 17:47   ` [PATCH 1/2] bonding: fix rtnl locking merge error Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4731CF83.20107@gmail.com \
    --to=monisonlists@gmail.com \
    --cc=fubar@us.ibm.com \
    --cc=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.