Re: [Qemu-devel] qemu qemu-doc.texi vl.c vl.h hw/mc146818rtc.c

[Fabrice Bellard <fabrice@bellard.org>]

Stefan Weil wrote:
> Hi,
> 
> the change from mc146818rtc.c might be needed for other timer
> implementations,
> too (because not all systems emulated by QEMU use mc146818rtc.c).
> 
> A list of candidates is here (fgrep gmtime, fgrep gettime):
> hw/m48t59.c:        gmtime_r (&t, tm);
> hw/omap.c:    s->convert = rtc_utc ? gmtime_r : localtime_r;
> hw/pl031.c:        tm = gmtime(&ti);
> hw/pxa2xx.c:        tm = gmtime(&ti);
> hw/etraxfs_timer.c:             gettimeofday(&now, NULL);
> 
> hw/omap.c needs additional changes for Windows, because gmtime_r
> is missing there.
> 
> Maybe all those locations should use a central function (to be written).

Right. There should be at least a function which returns the "current
time" with the rtc_utc flag handling.

Fabrice.