From: Fabrice Bellard <fabrice@bellard.org>
To: thayne@c2.net, qemu-devel@nongnu.org, paul@codesourcery.com
Subject: Re: [Qemu-devel] RFC: x86_64 Best way to fix 'cast to pointer from integer of different size' problems?
Date: Wed, 07 Nov 2007 20:18:06 +0100 [thread overview]
Message-ID: <47320F6E.5060505@bellard.org> (raw)
In-Reply-To: <1194314417.5154.176.camel@phantasm.home.enterpriseandprosperity.com>
Hi,
Regarding the user memory access, here is my suggestion which should
minimize the changes:
- Keep __put_user() and __get_user() as you did.
- Remove put_user(), get_user(), copy_from_user() and copy_to_user()
- Modify the signal.c code so that it uses __put_user, __get_user and
lock/unlock_user.
- Modify lock_user() so that it automatically does access_ok() and
returns NULL if access_ok() fails.
- Test lock_user/lock_user_struct/... return value explicitely at every
call.
- Fix page_check_range() so that it handles writes to pages containing
code by calling page_unprotect when necessary (the current code can fail
in this case !).
- Suppress no longer needed page_unprotect_range() call in syscall.c.
- Suppress or fix tput/tget macros so that they do access_ok().
Regards,
Fabrice.
next prev parent reply other threads:[~2007-11-07 19:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-03 17:26 [Qemu-devel] RFC: x86_64 Best way to fix 'cast to pointer from integer of different size' problems? TJ
2007-11-03 17:52 ` Paul Brook
2007-11-05 19:51 ` Thayne Harbaugh
2007-11-06 1:05 ` Paul Brook
2007-11-06 2:00 ` Thayne Harbaugh
2007-11-07 19:18 ` Fabrice Bellard [this message]
2007-11-07 20:59 ` Thayne Harbaugh
2007-11-07 23:02 ` Paul Brook
2007-11-12 16:42 ` Thayne Harbaugh
2007-11-06 20:05 ` Fabrice Bellard
2007-11-06 21:52 ` Stuart Anderson
2007-11-06 22:05 ` Paul Brook
2007-11-06 22:19 ` Stuart Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47320F6E.5060505@bellard.org \
--to=fabrice@bellard.org \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=thayne@c2.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.