From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1IpreW-0007G8-IM
	for mharc-grub-devel@gnu.org; Wed, 07 Nov 2007 15:37:32 -0500
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IpreV-0007EG-5U
	for grub-devel@gnu.org; Wed, 07 Nov 2007 15:37:31 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IpreU-0007CS-66
	for grub-devel@gnu.org; Wed, 07 Nov 2007 15:37:30 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IpreT-0007Bx-Rb
	for grub-devel@gnu.org; Wed, 07 Nov 2007 15:37:29 -0500
Received: from pne-smtpout3-sn1.fre.skanova.net ([81.228.11.120])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <chaac@nic.fi>) id 1IpreP-000768-Dq
	for grub-devel@gnu.org; Wed, 07 Nov 2007 15:37:30 -0500
Received: from [127.0.0.1] (88.193.32.97) by pne-smtpout3-sn1.fre.skanova.net
	(7.3.129) id 4717E5DD00113BA5 for grub-devel@gnu.org;
	Wed, 7 Nov 2007 21:37:05 +0100
Message-ID: <47322185.2040005@nic.fi>
Date: Wed, 07 Nov 2007 22:35:17 +0200
From: =?UTF-8?B?VmVzYSBKw6TDpHNrZWzDpGluZW4=?= <chaac@nic.fi>
User-Agent: Thunderbird 2.0.0.6 (Windows/20070728)
MIME-Version: 1.0
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <E1IpVtw-0001l3-2T@cvs.savannah.gnu.org> <4730DDB8.4090902@nic.fi>
	<20071107201907.GB10337@thorin>
In-Reply-To: <20071107201907.GB10337@thorin>
X-Enigmail-Version: 0.95.5
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: Quoted-Printable
X-detected-kernel: by monty-python.gnu.org: Solaris 10 (beta)
Subject: Re: grub2 ChangeLog term/i386/pc/serial.c
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Nov 2007 20:37:31 -0000

Robert Millan wrote:
> On Tue, Nov 06, 2007 at 11:33:44PM +0200, Vesa J=C3=A4=C3=A4skel=C3=A4i=
nen wrote:
>>> 		* term/i386/pc/serial.c (serial_hw_put): Switch order of arguments
>>> 		in grub_outb() calls.
>> Why on earth those parameters are reversed anyway :) ?
>=20
> My fault :-)
>=20
> When I replaced inb() and outb() in that file, I assumed they would hav=
e
> the same semantics as grub_inb() and grub_outb().

Just to be clear, I would have understood your rational ordering better
than current version ;)

> grub_inb() and grub_outb() are based on the inb()/outb() implementation
> from glibc headers, so I kept the same arguments for consistency.

I see... Once again inconsistency introduced by Unix folks... as AT&T
assembler wouldn't be enough, they then poisons C libs too... oh well...
another thing to try to keep in mind...