Re: [NFS] [PATCH 6/7] SUNRPC: Make call_status()/call_decode() call xprt_force_disconnect()

[Chuck Lever <chuck.lever@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]

Trond Myklebust wrote:
> From: Trond Myklebust <Trond.Myklebust@netapp.com>
> 
> Move the calls to xprt_disconnect() over to xprt_force_disconnect() in
> order to enable the transport layer to manage the state of the
> XPRT_CONNECTED flag.

Should xs_tcp_read_fraghdr() also use the new force disconnect?

> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
> ---
> 
>  net/sunrpc/clnt.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
> index 76be83e..046d8f6 100644
> --- a/net/sunrpc/clnt.c
> +++ b/net/sunrpc/clnt.c
> @@ -1137,7 +1137,7 @@ call_status(struct rpc_task *task)
>  	case -ETIMEDOUT:
>  		task->tk_action = call_timeout;
>  		if (task->tk_client->cl_discrtry)
> -			xprt_disconnect(task->tk_xprt);
> +			xprt_force_disconnect(task->tk_xprt);
>  		break;
>  	case -ECONNREFUSED:
>  	case -ENOTCONN:
> @@ -1260,7 +1260,7 @@ out_retry:
>  	req->rq_received = req->rq_private_buf.len = 0;
>  	task->tk_status = 0;
>  	if (task->tk_client->cl_discrtry)
> -		xprt_disconnect(task->tk_xprt);
> +		xprt_force_disconnect(task->tk_xprt);
>  }
>  
>  /*

[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 259 bytes --]

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture: Linux Projects Group
adr:;;1015 Granger Avenue;Ann Arbor;MI;48104;USA
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
version:2.1
end:vcard


[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
NFSv4 mailing list
NFSv4@linux-nfs.org
http://linux-nfs.org/cgi-bin/mailman/listinfo/nfsv4