From: Tejun Heo <htejun@gmail.com>
To: Greg KH <gregkh@suse.de>
Cc: Peter Osterlund <petero2@telia.com>,
Thomas Maier <balagi@justmail.de>,
Jens Axboe <jens.axboe@oracle.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pktcdvd: fix BUG caused by sysfs module reference semantics change
Date: Thu, 08 Nov 2007 15:55:55 +0900 [thread overview]
Message-ID: <4732B2FB.6000007@gmail.com> (raw)
In-Reply-To: <20071108052418.GA5670@suse.de>
Greg KH wrote:
> On Thu, Nov 08, 2007 at 11:27:16AM +0900, Tejun Heo wrote:
>> pkt_setup_dev() expects module reference to be held on invocation.
>> This used to be true for sysfs callbacks but not anymore. Test and
>> grab module reference around pkt_setup_dev() in
>> class_pktcdvd_store_add().
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>> Acked-by: Peter Osterlund <petero2@telia.com>
>> ---
>> Greg, can you please push this patch through your tree?
>> Thanks a lot.
>>
>> drivers/block/pktcdvd.c | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>
> Why through my tree? I don't do block devices :)
Because it's a regression introduced by changes in sysfs?
> Shouldn't Jens or at least Andrew take it?
That's fine too. Jens?
--
tejun
next prev parent reply other threads:[~2007-11-08 6:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071105092018.GD5359@kernel.dk>
2007-11-05 22:19 ` pktcdvd oops Peter Osterlund
2007-11-06 9:06 ` Tejun Heo
2007-11-06 21:07 ` Thomas Maier
2007-11-06 21:42 ` Peter Osterlund
2007-11-07 2:44 ` Tejun Heo
2007-11-07 22:06 ` Peter Osterlund
2007-11-08 2:27 ` [PATCH] pktcdvd: fix BUG caused by sysfs module reference semantics change Tejun Heo
2007-11-08 5:24 ` Greg KH
2007-11-08 6:55 ` Tejun Heo [this message]
2007-11-08 6:59 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4732B2FB.6000007@gmail.com \
--to=htejun@gmail.com \
--cc=balagi@justmail.de \
--cc=gregkh@suse.de \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=petero2@telia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.