From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5B9520E7; Sat, 20 Aug 2022 08:25:52 +0000 (UTC) Received: by mail-ed1-f45.google.com with SMTP id s11so8054833edd.13; Sat, 20 Aug 2022 01:25:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=B7LHKZXiDo4tLgHB6cmJPlzOB/uKwgbfurm+nzgUe+E=; b=p+dqT78pelXkOW0sDj8MLcQ5jX1HotYr5JkcBSFygVOwDxRBdEqt9xnq7TfqgW9/+p Zioh65SOtP1PQBtFhLNHyIWYjs8iP+mjthkm+Mj06v+ZoIpawrO92qRjK4uKqYx7ZMN2 ZoXQAOruFg/atZLgQLVeMO5rNMYwkLJ3YzRS7Fo9ROV+8x4xcWrh8JSHvhi8jCLgxJ85 o7vjehOb9IXISg+8lAqWiwr+QYO76WQl7WIUZy+HEWi+EssoTzCAGmTqq6U1y4KCFLVk 5ul1GMMEsNnj/rULYvT31AIzKywf7dfH7VS1ohtWtyAdAYXQiRYyBCs9hpahnC5S+jYp w4mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=B7LHKZXiDo4tLgHB6cmJPlzOB/uKwgbfurm+nzgUe+E=; b=QxutNO/GiGd8HJBzyO+ls92phLGILwHStuq3Ng3EZ5cLT67B7XppAOxKguBErggzRj yfLMlZmHm74jzCv6qSH/fv7WrOGhju9DvsHFRALAsyxVUfzv410x9IXII5uMlky9LTKj kh+xFV4fqaj99af9VCHtZQ4eE/v2zh+Ljy8wh5v87nuWO8usiaxZyYm/z7+gSbDAluHN 2wFPVl/NgJhPY1XPQtmb2gNu9gJMYkAYE4e2MEdkVgo+B2UN0EqnXP8bY2UoAtV4LZ/s keApA5SWG9oVN027/PvrjQoG5BnDDMnNmsE3MT3YPeYGOai5ZS5v9AHqvxqXauTACI23 ZIJw== X-Gm-Message-State: ACgBeo266g71LMBUTSa+CQ3AaoMVheHSurxgf2VR6+I85y/oUBS4sq/g 9/N9QIOVulsY/8wBObeYYLA= X-Google-Smtp-Source: AA6agR7J7U4+sJRzsXWy+KBWBJUbDx3IgOuhnw1m+2GDVVHCxRzhbKySXySLSCV3aGXB4BFAWw6fOA== X-Received: by 2002:a05:6402:5ca:b0:445:c80a:3c2 with SMTP id n10-20020a05640205ca00b00445c80a03c2mr8771757edx.247.1660983950869; Sat, 20 Aug 2022 01:25:50 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-1-172.dynamic.telemach.net. [82.149.1.172]) by smtp.gmail.com with ESMTPSA id d10-20020a50c88a000000b00445df5738dfsm4267553edh.73.2022.08.20.01.25.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Aug 2022 01:25:50 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-media@vger.kernel.org, Maxime Ripard , Paul Kocialkowski , Mauro Carvalho Chehab , Greg Kroah-Hartman , Chen-Yu Tsai , Samuel Holland , Nicolas Dufresne Cc: kernel@collabora.com, Dmitry Osipenko , stable@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/3] media: cedrus: Set the platform driver data earlier Date: Sat, 20 Aug 2022 10:25:48 +0200 Message-ID: <4733096.GXAFRqVoOG@jernej-laptop> In-Reply-To: <47ce07adc73887b5afaf9815a78b793d0e9a6b54.camel@collabora.com> References: <20220818203308.439043-1-nicolas.dufresne@collabora.com> <4418189.LvFx2qVVIh@jernej-laptop> <47ce07adc73887b5afaf9815a78b793d0e9a6b54.camel@collabora.com> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Dne petek, 19. avgust 2022 ob 17:37:20 CEST je Nicolas Dufresne napisal(a): > Le vendredi 19 ao=C3=BBt 2022 =C3=A0 06:17 +0200, Jernej =C5=A0krabec a = =C3=A9crit : > > Dne =C4=8Detrtek, 18. avgust 2022 ob 22:33:07 CEST je Nicolas Dufresne= =20 napisal(a): > > > From: Dmitry Osipenko > > >=20 > > > The cedrus_hw_resume() crashes with NULL deference on driver probe if > > > runtime PM is disabled because it uses platform data that hasn't been > > > set up yet. Fix this by setting the platform data earlier during prob= e. > >=20 > > Does it even work without PM? Maybe it would be better if Cedrus would > > select PM in Kconfig. >=20 > I cannot comment myself on this, but it does not seem to invalidate this > Dmitry's fix. If NULL pointer dereference happens only when PM is disabled, then it does.= I=20 have PM always enabled and I never experienced above issue. Best regards, Jernej >=20 > > Best regards, > > Jernej > >=20 > > > Cc: stable@vger.kernel.org > > > Signed-off-by: Dmitry Osipenko > > > Signed-off-by: Nicolas Dufresne > > > --- > > >=20 > > > drivers/staging/media/sunxi/cedrus/cedrus.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > >=20 > > > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus.c > > > b/drivers/staging/media/sunxi/cedrus/cedrus.c index > > > 960a0130cd620..55c54dfdc585c 100644 > > > --- a/drivers/staging/media/sunxi/cedrus/cedrus.c > > > +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c > > > @@ -448,6 +448,8 @@ static int cedrus_probe(struct platform_device > > > *pdev) > > >=20 > > > if (!dev) > > > =09 > > > return -ENOMEM; > > >=20 > > > + platform_set_drvdata(pdev, dev); > > > + > > >=20 > > > dev->vfd =3D cedrus_video_device; > > > dev->dev =3D &pdev->dev; > > > dev->pdev =3D pdev; > > >=20 > > > @@ -521,8 +523,6 @@ static int cedrus_probe(struct platform_device > > > *pdev) > > >=20 > > > goto err_m2m_mc; > > > =09 > > > } > > >=20 > > > - platform_set_drvdata(pdev, dev); > > > - > > >=20 > > > return 0; > > > =20 > > > err_m2m_mc: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48BB5C32772 for ; Sat, 20 Aug 2022 08:26:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JHvZTLvpwdgh1HbCKLgZqVzU6fBH0/YY4jglrmQilrU=; b=2o1cKWFduw0uHS OtcoHcGn65yJdPlVGIjs1cXaE0o1CteQhoNaMzK6tsCQ+wGoDauoXjvy0y/8L254u8olDHjVTCI1T sdFVZwdS+uNyLmcCTfy8CEIUY+IlIYi9FXOdv3owegtPZZOaD4e0UN1Uw7U9UEiaNzJ6sOLbFIDkO hWg5VkLW4nS4BSV3NCzNMkBQnAXVtRaW5Fa+s2cVcc2NGGLne59yu8w3FmBxorD0ghxoZlfbQ4x+k giOik4fv1lDR7RqyAwKbDuoabL3bj7hKMAlgctUZZQx85JGZYGot/mXhV2IiZgMzRtYrP8s768ibw w+ragZzF+WN9YDp8Pg6Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oPJnp-004oe4-DK; Sat, 20 Aug 2022 08:25:57 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oPJnl-004obR-TU for linux-arm-kernel@lists.infradead.org; Sat, 20 Aug 2022 08:25:55 +0000 Received: by mail-ed1-x531.google.com with SMTP id c39so8103043edf.0 for ; Sat, 20 Aug 2022 01:25:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=B7LHKZXiDo4tLgHB6cmJPlzOB/uKwgbfurm+nzgUe+E=; b=p+dqT78pelXkOW0sDj8MLcQ5jX1HotYr5JkcBSFygVOwDxRBdEqt9xnq7TfqgW9/+p Zioh65SOtP1PQBtFhLNHyIWYjs8iP+mjthkm+Mj06v+ZoIpawrO92qRjK4uKqYx7ZMN2 ZoXQAOruFg/atZLgQLVeMO5rNMYwkLJ3YzRS7Fo9ROV+8x4xcWrh8JSHvhi8jCLgxJ85 o7vjehOb9IXISg+8lAqWiwr+QYO76WQl7WIUZy+HEWi+EssoTzCAGmTqq6U1y4KCFLVk 5ul1GMMEsNnj/rULYvT31AIzKywf7dfH7VS1ohtWtyAdAYXQiRYyBCs9hpahnC5S+jYp w4mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=B7LHKZXiDo4tLgHB6cmJPlzOB/uKwgbfurm+nzgUe+E=; b=Ch9AkgO8Ce25g1/gaGtHnQy8II1zn72QvImvBjIykJnTzVVW6hvpbN6Zmh8xt7p36g CnagXW96Ld8aBliXR7BUcViEBQaXw+73KC5255UD4qCFhnu09LRVrg4JgxG84PxRjkyk by0EqdliU3/YjYkYsu1/M9Z2CKhAlnEkLkdsr1LTZvNGBj0rJfbM0INy1tWh2k/msTKQ HLX1NUkIUtKwqbqZ6THKC7T/P7/YVBi9nTHMyFzyIm6cvoxLV9Ese0K53f5LZUczo07i 3E6QdmDS0Hy8L1kavXosw8a26TRn9znHdkf6wIL7Nu8JO6R24a82rtGBcEQ1Yb6x3iJo Smdg== X-Gm-Message-State: ACgBeo2QsAPxy6Aj6ljgTqAkrBnYXBvkuX9sglEEtLsj8Ikbw2l/s59H VHlhAhH9CpW0uEv/Wn2jHGo= X-Google-Smtp-Source: AA6agR7J7U4+sJRzsXWy+KBWBJUbDx3IgOuhnw1m+2GDVVHCxRzhbKySXySLSCV3aGXB4BFAWw6fOA== X-Received: by 2002:a05:6402:5ca:b0:445:c80a:3c2 with SMTP id n10-20020a05640205ca00b00445c80a03c2mr8771757edx.247.1660983950869; Sat, 20 Aug 2022 01:25:50 -0700 (PDT) Received: from jernej-laptop.localnet (82-149-1-172.dynamic.telemach.net. [82.149.1.172]) by smtp.gmail.com with ESMTPSA id d10-20020a50c88a000000b00445df5738dfsm4267553edh.73.2022.08.20.01.25.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Aug 2022 01:25:50 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: linux-media@vger.kernel.org, Maxime Ripard , Paul Kocialkowski , Mauro Carvalho Chehab , Greg Kroah-Hartman , Chen-Yu Tsai , Samuel Holland , Nicolas Dufresne Cc: kernel@collabora.com, Dmitry Osipenko , stable@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/3] media: cedrus: Set the platform driver data earlier Date: Sat, 20 Aug 2022 10:25:48 +0200 Message-ID: <4733096.GXAFRqVoOG@jernej-laptop> In-Reply-To: <47ce07adc73887b5afaf9815a78b793d0e9a6b54.camel@collabora.com> References: <20220818203308.439043-1-nicolas.dufresne@collabora.com> <4418189.LvFx2qVVIh@jernej-laptop> <47ce07adc73887b5afaf9815a78b793d0e9a6b54.camel@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220820_012554_007332_1B0ACC48 X-CRM114-Status: GOOD ( 24.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RG5lIHBldGVrLCAxOS4gYXZndXN0IDIwMjIgb2IgMTc6Mzc6MjAgQ0VTVCBqZSBOaWNvbGFzIER1 ZnJlc25lIG5hcGlzYWwoYSk6Cj4gTGUgdmVuZHJlZGkgMTkgYW/Du3QgMjAyMiDDoCAwNjoxNyAr MDIwMCwgSmVybmVqIMWga3JhYmVjIGEgw6ljcml0IDoKPiA+IERuZSDEjWV0cnRlaywgMTguIGF2 Z3VzdCAyMDIyIG9iIDIyOjMzOjA3IENFU1QgamUgTmljb2xhcyBEdWZyZXNuZSAKbmFwaXNhbChh KToKPiA+ID4gRnJvbTogRG1pdHJ5IE9zaXBlbmtvIDxkbWl0cnkub3NpcGVua29AY29sbGFib3Jh LmNvbT4KPiA+ID4gCj4gPiA+IFRoZSBjZWRydXNfaHdfcmVzdW1lKCkgY3Jhc2hlcyB3aXRoIE5V TEwgZGVmZXJlbmNlIG9uIGRyaXZlciBwcm9iZSBpZgo+ID4gPiBydW50aW1lIFBNIGlzIGRpc2Fi bGVkIGJlY2F1c2UgaXQgdXNlcyBwbGF0Zm9ybSBkYXRhIHRoYXQgaGFzbid0IGJlZW4KPiA+ID4g c2V0IHVwIHlldC4gRml4IHRoaXMgYnkgc2V0dGluZyB0aGUgcGxhdGZvcm0gZGF0YSBlYXJsaWVy IGR1cmluZyBwcm9iZS4KPiA+IAo+ID4gRG9lcyBpdCBldmVuIHdvcmsgd2l0aG91dCBQTT8gTWF5 YmUgaXQgd291bGQgYmUgYmV0dGVyIGlmIENlZHJ1cyB3b3VsZAo+ID4gc2VsZWN0IFBNIGluIEtj b25maWcuCj4gCj4gSSBjYW5ub3QgY29tbWVudCBteXNlbGYgb24gdGhpcywgYnV0IGl0IGRvZXMg bm90IHNlZW0gdG8gaW52YWxpZGF0ZSB0aGlzCj4gRG1pdHJ5J3MgZml4LgoKSWYgTlVMTCBwb2lu dGVyIGRlcmVmZXJlbmNlIGhhcHBlbnMgb25seSB3aGVuIFBNIGlzIGRpc2FibGVkLCB0aGVuIGl0 IGRvZXMuIEkgCmhhdmUgUE0gYWx3YXlzIGVuYWJsZWQgYW5kIEkgbmV2ZXIgZXhwZXJpZW5jZWQg YWJvdmUgaXNzdWUuCgpCZXN0IHJlZ2FyZHMsCkplcm5lagoKPiAKPiA+IEJlc3QgcmVnYXJkcywK PiA+IEplcm5lago+ID4gCj4gPiA+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnCj4gPiA+IFNp Z25lZC1vZmYtYnk6IERtaXRyeSBPc2lwZW5rbyA8ZG1pdHJ5Lm9zaXBlbmtvQGNvbGxhYm9yYS5j b20+Cj4gPiA+IFNpZ25lZC1vZmYtYnk6IE5pY29sYXMgRHVmcmVzbmUgPG5pY29sYXMuZHVmcmVz bmVAY29sbGFib3JhLmNvbT4KPiA+ID4gLS0tCj4gPiA+IAo+ID4gPiAgZHJpdmVycy9zdGFnaW5n L21lZGlhL3N1bnhpL2NlZHJ1cy9jZWRydXMuYyB8IDQgKystLQo+ID4gPiAgMSBmaWxlIGNoYW5n ZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL3N0YWdpbmcvbWVkaWEvc3VueGkvY2VkcnVzL2NlZHJ1cy5jCj4gPiA+IGIv ZHJpdmVycy9zdGFnaW5nL21lZGlhL3N1bnhpL2NlZHJ1cy9jZWRydXMuYyBpbmRleAo+ID4gPiA5 NjBhMDEzMGNkNjIwLi41NWM1NGRmZGM1ODVjIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL3N0 YWdpbmcvbWVkaWEvc3VueGkvY2VkcnVzL2NlZHJ1cy5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvc3Rh Z2luZy9tZWRpYS9zdW54aS9jZWRydXMvY2VkcnVzLmMKPiA+ID4gQEAgLTQ0OCw2ICs0NDgsOCBA QCBzdGF0aWMgaW50IGNlZHJ1c19wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlCj4gPiA+ICpw ZGV2KQo+ID4gPiAKPiA+ID4gIAlpZiAoIWRldikKPiA+ID4gIAkKPiA+ID4gIAkJcmV0dXJuIC1F Tk9NRU07Cj4gPiA+IAo+ID4gPiArCXBsYXRmb3JtX3NldF9kcnZkYXRhKHBkZXYsIGRldik7Cj4g PiA+ICsKPiA+ID4gCj4gPiA+ICAJZGV2LT52ZmQgPSBjZWRydXNfdmlkZW9fZGV2aWNlOwo+ID4g PiAgCWRldi0+ZGV2ID0gJnBkZXYtPmRldjsKPiA+ID4gIAlkZXYtPnBkZXYgPSBwZGV2Owo+ID4g PiAKPiA+ID4gQEAgLTUyMSw4ICs1MjMsNiBAQCBzdGF0aWMgaW50IGNlZHJ1c19wcm9iZShzdHJ1 Y3QgcGxhdGZvcm1fZGV2aWNlCj4gPiA+ICpwZGV2KQo+ID4gPiAKPiA+ID4gIAkJZ290byBlcnJf bTJtX21jOwo+ID4gPiAgCQo+ID4gPiAgCX0KPiA+ID4gCj4gPiA+IC0JcGxhdGZvcm1fc2V0X2Ry dmRhdGEocGRldiwgZGV2KTsKPiA+ID4gLQo+ID4gPiAKPiA+ID4gIAlyZXR1cm4gMDsKPiA+ID4g IAo+ID4gPiAgZXJyX20ybV9tYzoKCgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==