From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 17/18] ide: cleanup ide_set_dma()
Date: Thu, 08 Nov 2007 16:36:51 +0300 [thread overview]
Message-ID: <473310F3.4040200@ru.mvista.com> (raw)
In-Reply-To: <200711050033.58423.bzolnier@gmail.com>
Bartlomiej Zolnierkiewicz wrote:
> * ->dma_off_quietly is always called before ide_set_dma()
> so the call can be moved inside ide_set_dma().
> * ide_dma_check() doesn't touch hardware so ->dma_off_quietly
> call for 'rc == -1' case is redundant, remove it.
> * '0' and '-1' are the only values returned by ide_dma_check()
> so remove dead code for other cases.
> There should be no functionality changes caused by this patch.
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
prev parent reply other threads:[~2007-11-08 13:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-04 23:33 [PATCH 17/18] ide: cleanup ide_set_dma() Bartlomiej Zolnierkiewicz
2007-11-08 13:36 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473310F3.4040200@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.